From owner-freebsd-net@FreeBSD.ORG  Wed Aug 18 18:21:07 2004
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DF6A816A4CE; Wed, 18 Aug 2004 18:21:07 +0000 (GMT)
Received: from pimout2-ext.prodigy.net (pimout2-ext.prodigy.net
	[207.115.63.101])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 72DD143D48; Wed, 18 Aug 2004 18:21:07 +0000 (GMT)
	(envelope-from julian@elischer.org)
Received: from elischer.org (adsl-68-124-233-133.dsl.snfc21.pacbell.net
	[68.124.233.133])i7IIKxfA161596;	Wed, 18 Aug 2004 14:21:00 -0400
Message-ID: <41239E0A.30508@elischer.org>
Date: Wed, 18 Aug 2004 11:20:58 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.4b) Gecko/20030524
X-Accept-Language: en, hu
MIME-Version: 1.0
To: John Polstra <jdp@polstra.com>
References: <XFMail.20040817094857.jdp@polstra.com>
In-Reply-To: <XFMail.20040817094857.jdp@polstra.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: freebsd-net@freebsd.org
cc: Harti Brandt <harti@freebsd.org>
cc: re@freebsd.org
cc: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
Subject: Re: netgraph only on i386/ia64 - why ?
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Aug 2004 18:21:08 -0000



John Polstra wrote:
> On 17-Aug-2004 Harti Brandt wrote:
> 
>>On Mon, 16 Aug 2004, Bjoern A. Zeeb wrote:
>>
>>BAZ>Hi,
>>BAZ>
>>BAZ>It seems netgraph is only build on ia64 and i386.
>>BAZ>Can someone please explain why ?
>>
>>Until around april I used all the ATM related Ng stuff regularily (this
>>include ng_socket, all the stuff under netgraph/atm). I think this should
>>just be enabled. Unless build problems have been introduced since then,
>>it should just be enabled.
> 
> 
> There is one problem with netgraph on 64-bit platforms.  The ng_msghdr
> struct is 52 bytes / 4-byte aligned (see ng_message.h).  That means
> the message payload is not well-aligned for 64-bit platforms.  It
> would be nice to fix that (and bump NG_VERSION, of course).  Nobody
> ever guaranteed that the message payload would be aligned, but it
> makes things a lot more convenient.

if we do this we should do it now so that we have a consistent ABI from 5.3 on..

scott (et al), should we pad an extra 4 bytes in this now?
it's low/no risk, but better now than after 5.3 has been released..



> 
> John
> _______________________________________________
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"