From owner-freebsd-current@FreeBSD.ORG Sun Feb 3 17:00:12 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9104D16A417 for ; Sun, 3 Feb 2008 17:00:12 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 5B5A013C46E for ; Sun, 3 Feb 2008 17:00:07 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.2/8.14.2/NETPLEX) with ESMTP id m13H030d013466; Sun, 3 Feb 2008 12:00:04 -0500 (EST) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-4.0 (mail.netplex.net [204.213.176.10]); Sun, 03 Feb 2008 12:00:04 -0500 (EST) Date: Sun, 3 Feb 2008 12:00:04 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= In-Reply-To: <861w7um5o5.fsf@ds4.des.no> Message-ID: References: <861w7um5o5.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-559023410-851401618-1202058004=:8686" Cc: threads@freebsd.org, current@freebsd.org Subject: Re: Symbol versioning errors in libthr X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Feb 2008 17:00:12 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---559023410-851401618-1202058004=:8686 Content-Type: TEXT/PLAIN; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Sun, 3 Feb 2008, Dag-Erling Sm=C3=B8rgrav wrote: > Here's an excerpt from the RELENG_7 vs HEAD diff of libthr's symbol map: > > --- pthread.map=0913 May 2007 14:12:39 -0000=091.18 > +++ pthread.map=0920 Dec 2007 04:32:28 -0000=091.21 > @@ -84,9 +84,13 @@ > =09pthread_multi_np; > =09pthread_mutex_destroy; > =09pthread_mutex_getprioceiling; > +=09pthread_mutex_getspinloops_np; > +=09pthread_mutex_getyieldloops_np; > =09pthread_mutex_init; > =09pthread_mutex_lock; > =09pthread_mutex_setprioceiling; > +=09pthread_mutex_setspinloops_np; > +=09pthread_mutex_setyieldloops_np; > =09pthread_mutex_timedlock; > =09pthread_mutex_trylock; > =09pthread_mutex_unlock; > > These functions are all in FBSD_1.0, but they were introduced after the > branch and never MFCed, so if I understand how we've implemented symbol > versioning, they should be in FBSD_1.1. > > Unless someone argues credibly for keeping them in FBSD_1.0, I will move > them to FBSD_1.1 in a few days. Yes, I believe you are correct in how we've decided to implement the version namespace. After a branch from HEAD (e.g., after 7- was branched), we increment the namespace and new symbols and ABI changes get added to the new namespace. --=20 DE ---559023410-851401618-1202058004=:8686--