From owner-svn-src-head@FreeBSD.ORG  Tue Mar 10 18:28:46 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 71769106568B;
	Tue, 10 Mar 2009 18:28:46 +0000 (UTC) (envelope-from guido@gvr.org)
Received: from gvr.gvr.org (gvr-gw.gvr.org [82.95.154.195])
	by mx1.freebsd.org (Postfix) with ESMTP id 2BD828FC3F;
	Tue, 10 Mar 2009 18:28:46 +0000 (UTC) (envelope-from guido@gvr.org)
Received: by gvr.gvr.org (Postfix, from userid 657)
	id ED12042D83C; Tue, 10 Mar 2009 19:01:57 +0100 (CET)
Date: Tue, 10 Mar 2009 19:01:57 +0100
From: Guido van Rooij <guido@gvr.org>
To: Fabian Keil <freebsd-listen@fabiankeil.de>
Message-ID: <20090310180157.GA4663@gvr.gvr.org>
References: <200903101523.n2AFNhs1065867@svn.freebsd.org>
	<20090310171948.1ac51696@fabiankeil.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090310171948.1ac51696@fabiankeil.de>
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, phk@freebsd.org
Subject: Re: svn commit: r189625 - head/sys/geom/eli
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Mar 2009 18:28:48 -0000

On Tue, Mar 10, 2009 at 05:19:48PM +0100, Fabian Keil wrote:
> > Log:
> >   When attaching a geli on boot make sure that it is detached
> >   upon last close. (needed for a gmirror to properly shutdown
> >   upon reboot when a geli is on top the gmirror)
> > 
> 
> Detach-on-last-close is known to cause panics when
> scrubbing at least some ZFS pools:
> http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/117158
> 
> Quoting the PR:
> |Quoting Pawel Jakub Dawidek's response to my initial report:
> ||GELI's detach-on-last-close mechanism is a general purpose mechanism, it
> ||may not work correctly with ZFS, because ZFS sometimes closes and reopen
> ||providers, which will make GELI to detach. In other words you shouldn't
> ||configure detach-on-last-close for ZFS components. 
> 

Grr. So we should make it tuneable. How about being able to set
this flag with the geli command, like the G_ELI_FLAG_BOOT flag.

-Guido