From owner-svn-ports-head@FreeBSD.ORG Mon Oct 8 17:09:56 2012 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 005241065672; Mon, 8 Oct 2012 17:09:55 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id A091F8FC16; Mon, 8 Oct 2012 17:09:54 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id jf20so2161025bkc.13 for ; Mon, 08 Oct 2012 10:09:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=UNA1AwiHS9zLnp32wt2bOIfJ2C8gfKg/ptw4oceXB1M=; b=dKE/Mp1fVDKBUXLr91gvAUKNBA9NEcPk05nQ0X+MSvzIRNjbXjQ4QgzyriqlrFsJjv N7l3mePPlm++BsLbJ4AIGENC38cGRvwnN/Leuo2OIHzXVEShJWU6OUxEPbVGoo5SiQbV dLrvxuTHR5XvPp1WFA5yFg/SejS7AIzd3iEfhbd5RU/31RXsEMobBXzbM2vP43ixqtEF M6xzuNVad1+PGB/Wb8S/VB9j2RtcOTnLvwQFP64WvycPxRDLh7SYfMpKYuXSMXCJJlmG guG9AUfc9bVmjQNXMNSP2us7O+lPJejhb+gAJwce0Ga78ihSbFcqNZ5RSnItDciLBz2s EjRQ== Received: by 10.205.137.7 with SMTP id im7mr5512497bkc.25.1349716193362; Mon, 08 Oct 2012 10:09:53 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.204.50.197 with HTTP; Mon, 8 Oct 2012 10:09:23 -0700 (PDT) In-Reply-To: <507307F7.3030406@FreeBSD.org> References: <201210061123.q96BNHVx053948@svn.freebsd.org> <20121008040154.GB91369@FreeBSD.org> <20121008045905.GD91369@FreeBSD.org> <20121008071642.GA91360@ithaqua.etoilebsd.net> <507307F7.3030406@FreeBSD.org> From: Chris Rees Date: Mon, 8 Oct 2012 18:09:23 +0100 X-Google-Sender-Auth: qYvit36N9wV8wVCQ6yYxpK2-S9Q Message-ID: To: Bryan Drewery Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-ports-head@freebsd.org, Baptiste Daroussin , Alexey Dokuchaev , svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r305357 - head/net/ssvnc X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2012 17:09:56 -0000 On 8 October 2012 18:05, Bryan Drewery wrote: > On 10/8/2012 12:02 PM, Chris Rees wrote: >> On 8 October 2012 08:16, Baptiste Daroussin wrote: >>> On Mon, Oct 08, 2012 at 04:59:06AM +0000, Alexey Dokuchaev wrote: >>>> On Mon, Oct 08, 2012 at 04:01:54AM +0000, Alexey Dokuchaev wrote: >>>>> On Sat, Oct 06, 2012 at 11:23:17AM +0000, Baptiste Daroussin wrote: >>>>>> New Revision: 305357 >>>>>> URL: http://svn.freebsd.org/changeset/ports/305357 >>>>>> >>>>>> Log: >>>>>> fix sense of a test >>>>>> >>>>>> -.if ${PORT_OPTIONS:MULTRAFTP} >>>>>> +.if empty(PORT_OPTIONS:MULTRAFTP) >>>>> >>>>> That looks weird, and commit message is pretty cryptic as well. Could you >>>>> explain what went wrong here so others would not fall in the same pitfall? >>>> >>>> Err, I read is as ! vs. empty() test. Still, I've noticved some arguments >>>> on the syntax, would be nice to know if ! ${PORT_OPTIONS:M...} has issues >>>> other than purely stylish. >>>> >>> >>> No it hasn't (as far as I know) >>> >> >> This is all my fault-- I was the one who suggested the original use of >> ${FOO:M}, and I deliberately chose to retain empty(FOO) as the reverse >> because I was convinced that the insanity of make's conditionals would >> screw us over in some way. >> >> I have at [1] pulled together some simple tests, and I think I've >> caught all use cases here. >> >> It seems to work fine-- are there any people more wizardly than me >> with make that can confirm that it's OK? If so, I'll update the docs. >> >> Chris >> >> [1] http://www.bayofrum.net/~crees/scratch/Makefile-do-we-need-empty-after-all >> > > Can you add: > > !${PORT_OPTIONS:MFOO} && !${PORT_OPTIONS:MBAR} > > I swear there is a case where !${} results in an Error. [crees@pegasus]~% cat Makefile ONE= two three four .if ${ONE:Mtwo} .warning ONE has two in it .endif .if !${ONE:Mfive} .warning ONE does not have five in it .endif .if !${ONE:Mfive} && ${ONE:Mblargh} .warning stuff? .endif .if !${ONE:Mfive} && ${ONE:Mone} .warning This is also fine .endif .if ${ONE:Mfive} || ${ONE:Msix} .warning So is this .endif .if !${ONE:Mfive} && !${ONE:Msix} .warning bdrewery is wrong .endif all: @: [crees@pegasus]~% make "Makefile", line 5: warning: ONE has two in it "Makefile", line 9: warning: ONE does not have five in it "Makefile", line 25: warning: bdrewery is wrong [crees@pegasus]~% :) Chris