From owner-svn-src-all@freebsd.org  Tue Dec 26 16:54:26 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 57ABAEA1FF1;
 Tue, 26 Dec 2017 16:54:26 +0000 (UTC)
 (envelope-from tuexen@freebsd.org)
Received: from drew.franken.de (mail-n.franken.de [193.175.24.27])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "*.franken.de",
 Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 1B5CA7DFA4;
 Tue, 26 Dec 2017 16:54:25 +0000 (UTC)
 (envelope-from tuexen@freebsd.org)
Received: from [192.168.1.204] (p57BB4707.dip0.t-ipconnect.de [87.187.71.7])
 (Authenticated sender: macmic)
 by mail-n.franken.de (Postfix) with ESMTPSA id 0E0A7721E280D;
 Tue, 26 Dec 2017 17:54:20 +0100 (CET)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\))
Subject: Re: svn commit: r327205 - head/sys/netinet/libalias
From: Michael Tuexen <tuexen@freebsd.org>
In-Reply-To: <20171226160000.GB90333@FreeBSD.org>
Date: Tue, 26 Dec 2017 17:54:18 +0100
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <6ED1D4C5-0A61-463D-AAB2-662E36D2E4FB@freebsd.org>
References: <201712261524.vBQFOggM046909@repo.freebsd.org>
 <20171226160000.GB90333@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
X-Mailer: Apple Mail (2.3445.5.20)
X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00
 autolearn=disabled version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Dec 2017 16:54:26 -0000

> On 26. Dec 2017, at 17:00, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
>=20
> On Tue, Dec 26, 2017 at 03:24:42PM +0000, Michael Tuexen wrote:
>> New Revision: 327205
>> URL: https://svnweb.freebsd.org/changeset/base/327205
>>=20
>> Log:
>>  Fix CID 1008936.
>=20
> I'm afraid this is a rather bad commit message.  It should have =
described
> what was the problem and how it was approached (fixed).  Listing CID =
is
> part of the metadata; it cannot replace proper commit log.
It replaced a comparison left side =3D=3D right side with identical left
and right sides with the correct condition. I guess that was a copy and =
paste error.
>=20
> Also, please do not mix functional and substantial amount of style =
changes
> in a single commit.
Yepp. You are right. Will do in the future...

Best regards
Michael
>=20
> ./danfe