From owner-freebsd-bugs@FreeBSD.ORG  Tue Dec  1 16:50:03 2009
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CEB5D1065679
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  1 Dec 2009 16:50:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id BD68D8FC22
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  1 Dec 2009 16:50:03 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nB1Go3H8023038
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 1 Dec 2009 16:50:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nB1Go3R4023037;
	Tue, 1 Dec 2009 16:50:03 GMT (envelope-from gnats)
Date: Tue, 1 Dec 2009 16:50:03 GMT
Message-Id: <200912011650.nB1Go3R4023037@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: "Oleg V. Nauman" <oleg@reis.zp.ua>
Cc: 
Subject: Re: bin/40282: [patch] kill(1) has bad error checking for command
	line parameters
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: "Oleg V. Nauman" <oleg@reis.zp.ua>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Dec 2009 16:50:03 -0000

The following reply was made to PR bin/40282; it has been noted by GNATS.

From: "Oleg V. Nauman" <oleg@reis.zp.ua>
To: Jilles Tjoelker <jilles@stack.nl>
Cc: bug-followup@freebsd.org, oleg@reis.zp.ua
Subject: Re: bin/40282: [patch] kill(1) has bad error checking for command line parameters
Date: Tue, 1 Dec 2009 18:14:29 +0200

  Hello Jilles,
 
 Thank you for looking into this.
 
 Your patch is fine, but it raises the next questions: do we really want to 
 keep historical kill(1) behavior regarding processing on the rest of list of 
 PIDs when an error occurs? Both of proposed patches ( mine and you ) just 
 break this historical behavior. Well I think that breaking the ( bad ) things 
 is the fine thing. Please commit your patch. 
 
  Thank you.
 
 On Sunday 08 November 2009 19:10:31 you wrote:
 > So I suggest this patch (EX_USAGE vs 1 can be changed separately).
 > 
 > -- 
 > Jilles Tjoelker
 > 
 > Index: bin/kill/kill.c
 > ===================================================================
 > --- bin/kill/kill.c     (revision 198703)
 > +++ bin/kill/kill.c     (working copy)
 > @@ -123,10 +123,9 @@
 > 
 >         for (errors = 0; argc; argc--, argv++) {
 >                 pid = strtol(*argv, &ep, 10);
 > -               if (!**argv || *ep) {
 > -                       warnx("illegal process id: %s", *argv);
 > -                       errors = 1;
 > -               } else if (kill(pid, numsig) == -1) {
 > +               if (!**argv || *ep)
 > +                       errx(1, "illegal process id: %s", *argv);
 > +               else if (kill(pid, numsig) == -1) {
 >                         warn("%s", *argv);
 >                         errors = 1;
 >                 }
 >