From owner-cvs-all  Sat Oct  3 18:09:11 1998
Return-Path: <owner-cvs-all>
Received: (from daemon@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id SAA01237
          for cvs-all-outgoing; Sat, 3 Oct 1998 18:09:11 -0700 (PDT)
          (envelope-from owner-cvs-all)
Received: from ns.mt.sri.com (sri-gw.MT.net [206.127.105.141])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id SAA01231;
          Sat, 3 Oct 1998 18:09:07 -0700 (PDT)
          (envelope-from nate@mt.sri.com)
Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100])
	by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id TAA23741;
	Sat, 3 Oct 1998 19:08:42 -0600 (MDT)
	(envelope-from nate@rocky.mt.sri.com)
Received: by mt.sri.com (SMI-8.6/SMI-SVR4)
	id TAA26613; Sat, 3 Oct 1998 19:08:41 -0600
Date: Sat, 3 Oct 1998 19:08:41 -0600
Message-Id: <199810040108.TAA26613@mt.sri.com>
From: Nate Williams <nate@mt.sri.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
To: Bruce Evans <bde@zeta.org.au>
Cc: jdp@FreeBSD.ORG, nate@mt.sri.com, cvs-all@FreeBSD.ORG,
        cvs-committers@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/i386/include asnames.h
In-Reply-To: <199810040105.LAA12996@godzilla.zeta.org.au>
References: <199810040105.LAA12996@godzilla.zeta.org.au>
X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid
Sender: owner-cvs-all@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> >>   Modified files:
> >>     sys/i386/include     asnames.h 
> >>   Log:
> >>   Two new C symbols were added to apm_setup.s but not put into
> >>   asnames.h.  That broke builds of ELF kernels.  *Whap*.
> >
> >This was done in June, *LONG* before ELF was even considered a
> >possibility.  Somehow this sort of thing has to change, since it's not
> 
> ELF was considered a possibility when asnames.h was added in April.  1997.

Not in my book.  Maybe in 'core', but certainly not to the 'peanut
gallery comitters'.

> >at all obvious that something needs to be added here (unless you get an
> >error after the fact and you know asnames is the right place to look.)
> 
> Committers should know about it.

Committers already have way too many other 'magic numbers' such as this
to worry about.  There are only so many brain cells left over to do
FreeBSD hacking that inconsistant kernel comitters have no chance of
getting it right, hence they shouldn't be committing, hence nothing gets
done. :(



Nate