From owner-freebsd-questions@FreeBSD.ORG Wed Aug 27 08:31:47 2003 Return-Path: Delivered-To: freebsd-questions@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3CD3116A4BF for ; Wed, 27 Aug 2003 08:31:47 -0700 (PDT) Received: from webserver.get-linux.org (adsl-64-161-78-226.dsl.lsan03.pacbell.net [64.161.78.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 6682443FBD for ; Wed, 27 Aug 2003 08:31:46 -0700 (PDT) (envelope-from oremanj@webserver.get-linux.org) Received: (qmail 27098 invoked by uid 1000); 27 Aug 2003 15:33:43 -0000 Date: Wed, 27 Aug 2003 08:33:43 -0700 From: Joshua Oreman To: Alexander Leidinger Message-ID: <20030827153343.GA27037@webserver> References: <20030817130114.2bfb3cf1.Alexander@Leidinger.net> <20030817133824.GA71246@madman.celabo.org> <20030818115928.20c1c570.Alexander@Leidinger.net> <20030827081036.GL47959@garage.freebsd.pl> <20030827111733.23d7bb71.Alexander@Leidinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030827111733.23d7bb71.Alexander@Leidinger.net> User-Agent: Mutt/1.4.1i cc: questions@freebsd.org Subject: Re: SecFix for databases/firebird, please review X-BeenThere: freebsd-questions@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: User questions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Aug 2003 15:31:47 -0000 On Wed, Aug 27, 2003 at 11:17:33AM +0200 or thereabouts, Alexander Leidinger wrote: > On Wed, 27 Aug 2003 10:10:36 +0200 > Pawel Jakub Dawidek wrote: > > > On Mon, Aug 18, 2003 at 11:59:28AM +0200, Alexander Leidinger wrote: > > +> Thanks for the review. I've updated > > +> http://www.leidinger.net/FreeBSD/firebird-1.0.2-secfix.tar.bz2 (modulo > > +> Chris' work in progress). I'm looking forward to the next round. :-) > > > > IMHO there are still problems with strncat(3). > > [ ... ] > > You also still don't add: > > > > buf[sizeof(buf) - 1] = '\0'; > > > > after all strncat(3)s. > > Hmmm... yes, I see the problem... >From strncat(3): char* strncat (char * restrict s, const char * restrict append, size_t count); [ ... ] The strncat function appends not more than count characters from append, and then adds a terminating `\0'. (emphasis added) ^^^^^^^^^^^^^^^^^^^^^^^ So here there really isn't a problem. -- Josh