From owner-freebsd-current@FreeBSD.ORG Mon Jan 2 22:51:59 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 841F51065672 for ; Mon, 2 Jan 2012 22:51:59 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 145DD15F110; Mon, 2 Jan 2012 22:51:57 +0000 (UTC) Message-ID: <4F02350D.2050500@FreeBSD.org> Date: Mon, 02 Jan 2012 14:51:57 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Garrett Cooper References: <4F023387.1060300@FreeBSD.org> In-Reply-To: X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Bjoern A. Zeeb" , FreeBSD current mailing list Subject: Re: periodic emails X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2012 22:51:59 -0000 On 01/02/2012 14:49, Garrett Cooper wrote: > On Mon, Jan 2, 2012 at 2:45 PM, Doug Barton wrote: >> On 01/02/2012 14:14, Garrett Cooper wrote: >> >>> How does this look for starters? The attached patch's goal is to >>> provide a generic, rc(5)-like infrastructure that would quiet down the >>> periodic emails for 120.clean-preserve . >> >> The periodic scripts are badly in need of attention, so effort in that >> area is much appreciated. >> >> Regarding your patch, rather than copying functions from rc.subr, why >> not just source it? Yes, you will get more than you need, but I think >> that the virtue of not having to maintain the same code in 2 places far >> outweighs that minor drawback. > > That works too, assuming that rc.subr isn't too rc(5) centric. Well of course it's rc-centric, but that's not the point. :) If you're going to be using the exact same code from rc.subr, you might as well just source it. The things that you'll get by doing that which are only relevant to rc you just ignore. > Thanks for the feedback! Glad to help. -- You can observe a lot just by watching. -- Yogi Berra Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/