From owner-svn-ports-all@FreeBSD.ORG Tue Dec 4 13:47:09 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 841D4287; Tue, 4 Dec 2012 13:47:09 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-yh0-f45.google.com (mail-yh0-f45.google.com [209.85.213.45]) by mx1.freebsd.org (Postfix) with ESMTP id EE16E8FC0C; Tue, 4 Dec 2012 13:47:07 +0000 (UTC) Received: by mail-yh0-f45.google.com with SMTP id p34so505752yhp.18 for ; Tue, 04 Dec 2012 05:47:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding:content-type; bh=54q1RyUnZoeYSR9xWOFpaZcQkRsBWZKTOaVDOY9lRb0=; b=ZQOEiwXtqoBg9qp/3sWwZKT4FFZCUs+24j6ktm4SB/5ucLiXG89nNsDLDLezBo88vr 2YTDNBRromWKpDs9zc79+ExS2f/VOkquCTXI/AhzZtbVbP2Qxh0ib489lsNa1COpADEN Kco9FU0nzanNskGGZXTmiBqZdXACTCjmu8Zde3j9uaDVvjU2vr3iB2Sx4/+qJQ56+YV0 6tRBD6ieKecfq39gPfoPT96vNZ+CyZx8NWYUWY7OXfDG/+k2sB1XZQuQpYwMhEg9OqDW JkAG9RL7d4qlGVd9v920RVl4PIofz43m/L0OPkOO2ayU+EnVQKrILyoGslokFjpbyR8c NX8g== Received: by 10.236.84.194 with SMTP id s42mr14715022yhe.17.1354628820930; Tue, 04 Dec 2012 05:47:00 -0800 (PST) Received: from mocha.verizon.net (c-71-61-40-68.hsd1.oh.comcast.net. [71.61.40.68]) by mx.google.com with ESMTPS id s1sm846717anj.1.2012.12.04.05.46.59 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 04 Dec 2012 05:47:00 -0800 (PST) Sender: "Jason E. Hale" From: "Jason E. Hale" To: Gabor Pali Subject: Re: svn commit: r308217 - in head/devel/icmake: . files Date: Tue, 04 Dec 2012 08:46:58 -0500 Message-ID: <3751237.XETYxtBKI8@mocha.verizon.net> User-Agent: KMail/4.8.4 (FreeBSD/9.0-RELEASE-p3; KDE/4.8.4; i386; ; ) In-Reply-To: References: <201212040913.qB49DUfk028183@svn.freebsd.org> <1837268.Hp4WNQ0tny@mocha.verizon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2012 13:47:09 -0000 On Tuesday, December 04, 2012 13:23:41 Gabor Pali wrote: > On Tue, Dec 4, 2012 at 12:45 PM, Jason E. Hale wrote: > > >> .if !defined(NOPORTDOCS) > > > > Should convert to ${PORT_OPTIONS:MDOCS} > > Hrm, I did not find any authoritative guidance on this. Once I asked > bapt about this, and he told me that keeping NOPORTDOCS is okay, if I > recall correctly. > Maybe bapt can comment, but we seem to be converting everything to OPTIONSng. This includes NOPORTDOCS, NOPORTEXAMPLES, WITHOUT_NLS, etc. AFAIK the prioity is to convert ports that use the old OPTIONS, but it would be good to convert the other variables as well if the opportunity arises. http://wiki.freebsd.org/Ports/Options/ConvertingToOptionsNG includes a check for all of those. > >> -WWW: http://icmake.sourceforge.net/ > >> +WWW: http://icmake.sourceforge.net/ > > > > Why the change to tab? Single space is the standard. > > Why not? :-) I use tabs after "WWW:" in pkg-descr for all of my > ports. Is this in the Porter's Handbook? > danfe pretty much covered this. The example in PH also shows single space: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting- desc.html#AEN95 > >> @comment $FreeBSD$ > > > > ^ This isn't neccessary. Tools/scripts/psvn should be used to set the > > props correctly. > > Yes, I know, but this is also kind of a habit that I maintain for my > ports. Does it cause any problems? > I have seen this used as a workaround for incorrect svn props and I assumed that is what this was. I don't know that it causes problems exactly, but it is certainly non-standard which makes curious people like me question why it is there. :) http://wiki.freebsd.org/PortsSubversionPrimer says the props for pkg-* should be: svn:eol-style=native; fbsd:nokeywords=yes; svn:mime-type=text/plain so I'm extrapolating that the FreeBSD keyword should not be in there. -- Jason E. Hale - jhale@ FreeBSD Ports Committer KDE/FreeBSD Team