From owner-svn-ports-head@FreeBSD.ORG Mon Jul 14 08:04:29 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 758E6F1; Mon, 14 Jul 2014 08:04:29 +0000 (UTC) Received: from mailrelay007.isp.belgacom.be (mailrelay007.isp.belgacom.be [195.238.6.173]) by mx1.freebsd.org (Postfix) with ESMTP id 93FFB2B29; Mon, 14 Jul 2014 08:04:28 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmwGAE6Ow1NbsKzB/2dsb2JhbABYgw5Swh6HQwGBFRd1hAQBBTocHgUQCw4GBAklDyoeBohZAQjHEhePGDMHhEMBBJsNgUuSU4NGOw Received: from 193.172-176-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.176.172.193]) by relay.skynet.be with ESMTP; 14 Jul 2014 10:04:27 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id s6E84QUD001976; Mon, 14 Jul 2014 10:04:26 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Mon, 14 Jul 2014 10:04:25 +0200 From: Tijl Coosemans To: John Marino Subject: Re: svn commit: r361725 - head/devel/psptoolchain-binutils Message-ID: <20140714100425.6efaa62c@kalimero.tijl.coosemans.org> In-Reply-To: <53C38DCF.4040403@marino.st> References: <201407132320.s6DNKZG6065320@svn.freebsd.org> <20140714093658.3d11990a@kalimero.tijl.coosemans.org> <53C38DCF.4040403@marino.st> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, John Marino , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jul 2014 08:04:29 -0000 On Mon, 14 Jul 2014 09:59:11 +0200 John Marino wrote: > On 7/14/2014 09:36, Tijl Coosemans wrote: >> On Sun, 13 Jul 2014 23:20:35 +0000 (UTC) John Marino wrote: >>> Author: marino >>> Date: Sun Jul 13 23:20:34 2014 >>> New Revision: 361725 >>> URL: http://svnweb.freebsd.org/changeset/ports/361725 >>> QAT: https://qat.redports.org/buildarchive/r361725/ >>> >>> Log: >>> devel/psptoolchain-binutils: Fix stage support for DragonFly >>> >>> The configure target was hardcoded for FreeBSD. This change fixes the >>> build on DragonFly while being a No-Op for FreeBSD. >>> >>> Modified: >>> head/devel/psptoolchain-binutils/Makefile >>> >>> Modified: head/devel/psptoolchain-binutils/Makefile >>> ============================================================================== >>> --- head/devel/psptoolchain-binutils/Makefile Sun Jul 13 23:13:32 2014 (r361724) >>> +++ head/devel/psptoolchain-binutils/Makefile Sun Jul 13 23:20:34 2014 (r361725) >>> @@ -17,7 +17,7 @@ USES= gmake tar:bzip2 libtool >>> USE_GCC= any >>> >>> HAS_CONFIGURE= yes >>> -CONFIGURE_TARGET= ${ARCH:S/amd64/x86_64/}-unknown-freebsd${OSREL} >>> +CONFIGURE_TARGET= ${ARCH:S/amd64/x86_64/}-unknown-${OPSYS:tl}${OSREL} >>> CONFIGURE_ARGS= --prefix=${PREFIX} \ >>> --target="psp" \ >>> --enable-install-libbfd \ >> >> You should probably scan the entire tree for cases like this and modify >> bsd.port.mk as well because that's where it gets copy-pasted from. > > bsd.port.mk has been adjusted automatically for dports so that's fine. > The only issue comes when ports try to override the CONFIGURE_TARGET, > often unnecessarily. Over the last year, I've either gotten most of > them or I've handled it with local patches. If you don't modify bsd.port.mk these kind of problems will keep popping up forever.