From owner-svn-ports-head@FreeBSD.ORG Mon Jul 14 08:09:25 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 840E3261; Mon, 14 Jul 2014 08:09:25 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 598082B5E; Mon, 14 Jul 2014 08:09:25 +0000 (UTC) Received: from [192.168.0.22] (unknown [130.255.19.191]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 0149143B9B; Mon, 14 Jul 2014 03:09:08 -0500 (CDT) Message-ID: <53C39013.1040804@marino.st> Date: Mon, 14 Jul 2014 10:08:51 +0200 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Tijl Coosemans Subject: Re: svn commit: r361725 - head/devel/psptoolchain-binutils References: <201407132320.s6DNKZG6065320@svn.freebsd.org> <20140714093658.3d11990a@kalimero.tijl.coosemans.org> <53C38DCF.4040403@marino.st> <20140714100425.6efaa62c@kalimero.tijl.coosemans.org> In-Reply-To: <20140714100425.6efaa62c@kalimero.tijl.coosemans.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jul 2014 08:09:25 -0000 On 7/14/2014 10:04, Tijl Coosemans wrote: > On Mon, 14 Jul 2014 09:59:11 +0200 John Marino wrote: >> On 7/14/2014 09:36, Tijl Coosemans wrote: >>> On Sun, 13 Jul 2014 23:20:35 +0000 (UTC) John Marino wrote: >>>> Author: marino >>>> Date: Sun Jul 13 23:20:34 2014 >>>> New Revision: 361725 >>>> URL: http://svnweb.freebsd.org/changeset/ports/361725 >>>> QAT: https://qat.redports.org/buildarchive/r361725/ >>>> >>>> Log: >>>> devel/psptoolchain-binutils: Fix stage support for DragonFly >>>> >>>> The configure target was hardcoded for FreeBSD. This change fixes the >>>> build on DragonFly while being a No-Op for FreeBSD. >>>> >>>> Modified: >>>> head/devel/psptoolchain-binutils/Makefile >>>> >>>> Modified: head/devel/psptoolchain-binutils/Makefile >>>> ============================================================================== >>>> --- head/devel/psptoolchain-binutils/Makefile Sun Jul 13 23:13:32 2014 (r361724) >>>> +++ head/devel/psptoolchain-binutils/Makefile Sun Jul 13 23:20:34 2014 (r361725) >>>> @@ -17,7 +17,7 @@ USES= gmake tar:bzip2 libtool >>>> USE_GCC= any >>>> >>>> HAS_CONFIGURE= yes >>>> -CONFIGURE_TARGET= ${ARCH:S/amd64/x86_64/}-unknown-freebsd${OSREL} >>>> +CONFIGURE_TARGET= ${ARCH:S/amd64/x86_64/}-unknown-${OPSYS:tl}${OSREL} >>>> CONFIGURE_ARGS= --prefix=${PREFIX} \ >>>> --target="psp" \ >>>> --enable-install-libbfd \ >>> >>> You should probably scan the entire tree for cases like this and modify >>> bsd.port.mk as well because that's where it gets copy-pasted from. >> >> bsd.port.mk has been adjusted automatically for dports so that's fine. >> The only issue comes when ports try to override the CONFIGURE_TARGET, >> often unnecessarily. Over the last year, I've either gotten most of >> them or I've handled it with local patches. > > If you don't modify bsd.port.mk these kind of problems will keep > popping up forever. Oh, I get what you mean -- that it's a bad template that people will keep copying. Okay, point taken. I'll try to update that soon. John