Date: Mon, 14 Jul 2014 10:08:51 +0200 From: John Marino <freebsd.contact@marino.st> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r361725 - head/devel/psptoolchain-binutils Message-ID: <53C39013.1040804@marino.st> In-Reply-To: <20140714100425.6efaa62c@kalimero.tijl.coosemans.org> References: <201407132320.s6DNKZG6065320@svn.freebsd.org> <20140714093658.3d11990a@kalimero.tijl.coosemans.org> <53C38DCF.4040403@marino.st> <20140714100425.6efaa62c@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/14/2014 10:04, Tijl Coosemans wrote: > On Mon, 14 Jul 2014 09:59:11 +0200 John Marino wrote: >> On 7/14/2014 09:36, Tijl Coosemans wrote: >>> On Sun, 13 Jul 2014 23:20:35 +0000 (UTC) John Marino wrote: >>>> Author: marino >>>> Date: Sun Jul 13 23:20:34 2014 >>>> New Revision: 361725 >>>> URL: http://svnweb.freebsd.org/changeset/ports/361725 >>>> QAT: https://qat.redports.org/buildarchive/r361725/ >>>> >>>> Log: >>>> devel/psptoolchain-binutils: Fix stage support for DragonFly >>>> >>>> The configure target was hardcoded for FreeBSD. This change fixes the >>>> build on DragonFly while being a No-Op for FreeBSD. >>>> >>>> Modified: >>>> head/devel/psptoolchain-binutils/Makefile >>>> >>>> Modified: head/devel/psptoolchain-binutils/Makefile >>>> ============================================================================== >>>> --- head/devel/psptoolchain-binutils/Makefile Sun Jul 13 23:13:32 2014 (r361724) >>>> +++ head/devel/psptoolchain-binutils/Makefile Sun Jul 13 23:20:34 2014 (r361725) >>>> @@ -17,7 +17,7 @@ USES= gmake tar:bzip2 libtool >>>> USE_GCC= any >>>> >>>> HAS_CONFIGURE= yes >>>> -CONFIGURE_TARGET= ${ARCH:S/amd64/x86_64/}-unknown-freebsd${OSREL} >>>> +CONFIGURE_TARGET= ${ARCH:S/amd64/x86_64/}-unknown-${OPSYS:tl}${OSREL} >>>> CONFIGURE_ARGS= --prefix=${PREFIX} \ >>>> --target="psp" \ >>>> --enable-install-libbfd \ >>> >>> You should probably scan the entire tree for cases like this and modify >>> bsd.port.mk as well because that's where it gets copy-pasted from. >> >> bsd.port.mk has been adjusted automatically for dports so that's fine. >> The only issue comes when ports try to override the CONFIGURE_TARGET, >> often unnecessarily. Over the last year, I've either gotten most of >> them or I've handled it with local patches. > > If you don't modify bsd.port.mk these kind of problems will keep > popping up forever. Oh, I get what you mean -- that it's a bad template that people will keep copying. Okay, point taken. I'll try to update that soon. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53C39013.1040804>