Date: Tue, 22 Jan 2002 12:56:48 +0200 From: Peter Pentchev <roam@ringlet.net> To: green@FreeBSD.org Cc: re@FreeBSD.org, arch@FreeBSD.ORG Subject: Re: sftp, glob(3) and GLOB_NOMATCH - urgent before 4.5-R! Message-ID: <20020122125648.A1743@straylight.oblivion.bg> In-Reply-To: <XFMail.20020121002603.mheffner@vt.edu>; from mheffner@vt.edu on Mon, Jan 21, 2002 at 12:26:03AM -0500 References: <20020120224344.A15845@straylight.oblivion.bg> <XFMail.20020121002603.mheffner@vt.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
OK then; Brian, what do you think of patching the FreeBSD version of OpenSSH for the present? What do the Release Engineers think of MFC'ing this in time for 4.5-RELEASE? G'luck, Peter -- This sentence every third, but it still comprehensible. On Mon, Jan 21, 2002 at 12:26:03AM -0500, Mike Heffner wrote: > Well, IEEE 1003.1-2001 states that glob(3) should return GLOB_NOMATCH, > but, as noticed, this hasn't been implemented in glob(3) yet. IMO, since > we are so close to 4.5R, we should commit the local change in the PR to > OpenSSH and worry about implementing GLOB_NOMATCH (and the other options > that are lacking in glob(3)) after 4.5R. The change in the PR will be > forwards compatible when it comes to implementing GLOB_NOMATCH. In > anycase, the (untested) patch below should be enough to implement > GLOB_NOMATCH. > > On 20-Jan-2002 Peter Pentchev wrote: > | Hi, > | > | In FreeBSD PR 34019, the submitter discusses an sftp core dump when > | a nonexistent file is uploaded. I found out that the same bug > | exists on uploading, and that it is caused by the fact that sftp > | expects glob(3) to error out when no matches are found. I opened > | up an OpenSSH problem report (bug id 73 in the mindrot.org database) > | and soon afterwards, I received the attached reply, which was CC'd > | to our GNATS. > | > | So.. somebody who is acquainted with standards, compatiblity, POLA > | and stuff - how do we go about this? Do we commit the fix in the > | audit trail of PR 34019, thus making another local change to OpenSSH? > | Do we change glob(3)'s behavior to return GLOB_NOMATCH? Or do we ship > | 4.5 with a known bad sftp client? :) I've CC'd Damien Miller (thanks > | for the fast response!) so that the OpenSSH folks are also aware of > | this discussion. > | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020122125648.A1743>