From owner-svn-ports-all@FreeBSD.ORG  Mon Aug 25 09:32:43 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 5DC24ADD; Mon, 25 Aug 2014 09:32:43 +0000 (UTC)
Date: Mon, 25 Aug 2014 09:32:43 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Adam Weinberger <adamw@FreeBSD.org>
Subject: Re: svn commit: r365735 - in head/games: . prboom-plus
Message-ID: <20140825093243.GC66191@FreeBSD.org>
References: <201408231404.s7NE4Ds7036892@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201408231404.s7NE4Ds7036892@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Aug 2014 09:32:43 -0000

On Sat, Aug 23, 2014 at 02:04:13PM +0000, Adam Weinberger wrote:
> New Revision: 365735
> URL: http://svnweb.freebsd.org/changeset/ports/365735
> QAT: https://qat.redports.org/buildarchive/r365735/
> 
> @@ -0,0 +1,43 @@
> +# Created by: Jordan DeLong <fracture@allusion.net>
> +# $FreeBSD$
> +
> +PORTNAME=	prboom-plus
> +PORTVERSION=	2.5.1.3
> +CATEGORIES=	games
> +MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTVERSION}
> +
> +MAINTAINER=	thiagohero501@gmail.com
> +COMMENT=	A fork of the doom game engine prboom

COMMENT line is wrong. :)

> Added: head/games/prboom-plus/Makefile.include
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/games/prboom-plus/Makefile.include	Sat Aug 23 14:04:12 2014	(r365735)
> @@ -0,0 +1,24 @@
> +# Makefile for defining variables used by other Doom related ports.
> +
> +DMPKGNAMEPREFIX?=	doom-
> +DMDIR?=		${LOCALBASE}/share/doom
> +
> +.if defined(PKGNAMEPREFIX) && ${PKGNAMEPREFIX} == ${DMPKGNAMEPREFIX} && defined(OPTIONSMKINCLUDED)
> +.  error include before <bsd.port.options.mk> if using DMPKGNAMEPREFIX
> +.endif
> +
> +MAKE_ENV+=	DMDIR="${DMDIR}"
> +PLIST_SUB+=	DMDIR="${DMDIR:S/${LOCALBASE}\///}"
> +SUB_LIST+=	DMDIR="${DMDIR}"
> +
> +.if defined(USE_CRLF)
> +.   if defined(USE_ZIP)
> +EXTRACT_BEFORE_ARGS=	-aqo
> +.   else
> +pre-patch:
> +	@${FIND} ${WRKDIR} -type f -print0 | \
> +		${XARGS} -0 ${FILE} | ${GREP} 'CRLF' | \
> +		${SED} -e "s/:.*//" | ${SED} -e 's/ /\\ /g' | \
> +		${XARGS} ${REINPLACE_CMD} -i "" -e "s/`${PRINTF} '\r'`$$//"
> +.   endif
> +.endif

This looks like the old version of the doom-data/Makefile.include file.  Why
it was copied here.  Submitter should've taken a look at other Doom ports to
see how to properly use this file.

It would be nice to have this patch first reviewed by games@.

./danfe