From owner-svn-src-head@FreeBSD.ORG Fri Oct 24 13:27:03 2008 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 816ED106567E; Fri, 24 Oct 2008 13:27:03 +0000 (UTC) Date: Fri, 24 Oct 2008 13:27:03 +0000 From: Alexey Dokuchaev To: Dag-Erling Sm??rgrav Message-ID: <20081024132703.GA81378@FreeBSD.org> References: <200810230151.m9N1ptUe044619@svn.freebsd.org> <20081023.190942.74668946.imp@bsdimp.com> <868wsewzos.fsf@ds4.des.no> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <868wsewzos.fsf@ds4.des.no> User-Agent: Mutt/1.4.2.1i Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, marcel@FreeBSD.org, Warner Losh , src-committers@FreeBSD.org Subject: Re: svn commit: r184193 - in head/sys: arm/conf conf X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Oct 2008 13:27:03 -0000 On Fri, Oct 24, 2008 at 03:26:43AM +0200, Dag-Erling Sm??rgrav wrote: > Warner Losh writes: > > We already have a better mechanism for including config files. We > > should be using that instead of poluting another port with the > > DEFAULTS file. > > Should we even have DEFAULTS files at all? IMHO they just confuse > matters by introducing "stealth" options into your config. I tend to second this. I always try to get everything possible out of my kernel to modules, and thus was surprised to see io.ko and mem.ko fail to load because they were silently included into my custom kernel. I understand that some things like 'device isa' and 'device npx' aren't really optional, but if something is useful to have, but can be loaded as a module, it belongs to GENERIC rather than DEFAULTS. Killing the latter altogether and throwing a comment that says particular option or device is mandatory in GENERIC is probably even better (and more transparent). ./danfe