From owner-freebsd-net Thu Feb 3 3:43:56 2000 Delivered-To: freebsd-net@freebsd.org Received: from euitt.upm.es (haddock.euitt.upm.es [138.100.52.102]) by builder.freebsd.org (Postfix) with ESMTP id C20164384 for ; Thu, 3 Feb 2000 03:43:46 -0800 (PST) Received: from localhost (pjlobo@localhost) by euitt.upm.es (8.9.3/8.9.3) with ESMTP id MAA24043; Thu, 3 Feb 2000 12:30:33 +0100 (MET) Date: Thu, 3 Feb 2000 12:30:33 +0100 (MET) From: "Pedro J. Lobo" To: "Matthew N. Dodd" Cc: Jasper Wallace , Mike Nowlin , freebsd-net@FreeBSD.ORG Subject: Re: 802.1Q VLANs In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Wed, 2 Feb 2000, Matthew N. Dodd wrote: >Ok, I've reviewed the patches (crap) and fixed the problem (easy). I agree that the patches aren't the perfect solution. As I said, they were a quick and dirty hack. When I posted them, I received a commment from Garrett Wollman (which I never answered, sorry Garrett), who also didn't like them. >I'm not terribly happy with how the double queuing ends up working but its >much better than polluting sys/net/if_ethersubr.c with all sorts of VLAN >defines. Also agreed. I did it that way because although I didn't like the double queuing, it should have worked, and I didn't find any obvious error. >The correct solution will be to write a vlan_output() routine that does >the right thing so we can place packets right on the parent interface's >queue instead of calling ether_output twice. Yes, that would be a nice approach. >I'm not inclined to do this so close to release so the brief patch will >have to do. I have *tons* of "real" work to do right now, but I'll test it as soon as I can. Cheers, Pedro. -- ------------------------------------------------------------------- Pedro José Lobo Perea Tel: +34 91 336 78 19 Centro de Cálculo Fax: +34 91 331 92 29 E.U.I.T. Telecomunicación e-mail: pjlobo@euitt.upm.es Universidad Politécnica de Madrid Ctra. de Valencia, Km. 7 E-28031 Madrid - España / Spain To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message