From owner-cvs-ports Tue Jun 3 05:19:42 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id FAA24951 for cvs-ports-outgoing; Tue, 3 Jun 1997 05:19:42 -0700 (PDT) Received: from nexis.net (customer-1.ican.net [198.133.36.101]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id FAA24937; Tue, 3 Jun 1997 05:19:37 -0700 (PDT) Received: from localhost (james@localhost) by nexis.net (8.8.5/8.8.5) with SMTP id IAA26193; Tue, 3 Jun 1997 08:10:07 -0400 (EDT) Date: Tue, 3 Jun 1997 08:10:07 -0400 (EDT) From: James FitzGibbon To: Satoshi Asami cc: cvs-committers@freebsd.org, cvs-all@freebsd.org, cvs-ports@freebsd.org Subject: Re: cvs commit: ports/news/diablo - Imported sources In-Reply-To: <199706031029.DAA01048@silvia.HIP.Berkeley.EDU> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-ports@freebsd.org X-Loop: FreeBSD.org Precedence: bulk On Tue, 3 Jun 1997, Satoshi Asami wrote: > What you should probably do is change this to pkg/REQ or something so > package users can use it too. I recommend you add a question at the > beginning about changing the environment of user news. Please > condition it on "BATCH" being defined and pass ${SCRIPTS_ENV} to it > when you call it from pre-install (see bsd.port.mk). I admit I've never paid much attention to the additional hooks in the pkg files. There must be a few I'm not up-to-date on, since I've never heard of pkg/REQ before. As for the user, I suppose nothing will break if the user isn't defined correctly; The startup script has doesn't even start diablo until you manually uncomment it (if I let it, anyone who installed the package would try to hose the author's new hub) 8-) I'll take a look at it and Rwhois on a current system asap. -- j.