From owner-freebsd-hackers@FreeBSD.ORG Wed Jun 22 17:27:41 2011 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 421B610656A4; Wed, 22 Jun 2011 17:27:41 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id F05EB8FC1E; Wed, 22 Jun 2011 17:27:40 +0000 (UTC) Received: by iwr19 with SMTP id 19so1209635iwr.13 for ; Wed, 22 Jun 2011 10:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:from :date:x-google-sender-auth:message-id:subject:to:cc:content-type; bh=4x0KVLyMdwnr2zlumnt+KWI5FSjop6HSw11V8K/+pPA=; b=CoH0DzmY3xho2zdWj35ccCvib2lSFhjTH5zhOm8UYCWFWYmUuY8NjA+tZmqcWyVxnx qXfXBclWzpr4eB21fCzsruHKJ8On4/qJ0BKMbbMi8CUU6r33uRtdLYSEp2FEdZNpRl/a ijzaDIATn2j4uQHnrEaNzM9XtK9g9p5RC5UiQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; b=G9+EjO1oABOgZP0DiZ/hDT1PUVk60JifDhmrxylOn5x8VlTX4P9ijg5gbdYAa1Lzub cVjNejEsxmewOW4oLXr7Lzfwgx3XpXPqU51EcgMR4QRO5gUZTtWFBDGNtgk4AcP9wMbj lWbY4nltzPrMr6VcsufFjNMLx4aTv3ztZIOMU= Received: by 10.42.147.137 with SMTP id n9mr909538icv.383.1308763660171; Wed, 22 Jun 2011 10:27:40 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.49.193 with HTTP; Wed, 22 Jun 2011 10:27:10 -0700 (PDT) In-Reply-To: References: <379A724C-4458-4E5C-81E9-CF125666E203@FreeBSD.org> From: Chris Rees Date: Wed, 22 Jun 2011 18:27:10 +0100 X-Google-Sender-Auth: PyhNe2hqQEf5sfOlt0c0g_Aj5fc Message-ID: To: Henrik Brix Andersen Content-Type: text/plain; charset=ISO-8859-1 Cc: hackers@freebsd.org Subject: Re: CONF class of files X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2011 17:27:41 -0000 On 19 June 2011 10:14, Henrik Brix Andersen wrote: > On Jun 19, 2011, at 10:50, Chris Rees wrote: >> On 19 June 2011 09:15, Henrik Brix Andersen wrote: >>> >>> On Jun 17, 2011, at 18:40, Chris Rees wrote: >>>> Macros are being tested for bsd.port.mk that use a new class of files, >>>> in the same vein as the BINOWN variables I have introduced CONFOWN, >>>> CONFGRP, CONFMODE and CONFDIR. >>>> >>>> Please would someone review and give an opinion on [1]? >>> >>> Shouldn't $CONFDIR be set to ${PREFIX}/etc/ instead of /etc? >>> >>> Also, if we define $CONFDIR, we should use it everywhere in bsd.*.mk where we currently use some form of */etc/* - otherwise we will get a mismatch if $CONFDIR is changed from the default. >> >> CONFDIR is for base, not ports, just like most other stuff in that >> file. Have a look at the other DIR variables. > > Gah, I was confused by you initial mail mentioning bsd.port.mk. > > Rereading the patch, I think it looks good. I'd love to see this go in before 9.0 as well. > Hey guys, Now we've had a bit of interest in this PR, can someone please type the magic words before the freeze? Chris http://www.freebsd.org/cgi/query-pr.cgi?pr=misc/157062