From owner-freebsd-bugs@freebsd.org  Tue Nov  3 06:52:53 2015
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3E78CA244FE
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Tue,  3 Nov 2015 06:52:53 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 29FFC115C
 for <freebsd-bugs@FreeBSD.org>; Tue,  3 Nov 2015 06:52:53 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tA36qr6u065325
 for <freebsd-bugs@FreeBSD.org>; Tue, 3 Nov 2015 06:52:53 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 204230] [patch] bsdiff(1) - check file size against SIZE_MAX
Date: Tue, 03 Nov 2015 06:52:52 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: misc
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: ache@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-204230-8-pwBdjbrmb9@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-204230-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-204230-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Nov 2015 06:52:53 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204230

--- Comment #3 from Andrey A. Chernov <ache@FreeBSD.org> ---
Comment on attachment 162714
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=162714
proposed fix

This fix is not pretty. 
1) It does not set errno (EFBIG)
2) Next overflow is few lines below:
if(((I=malloc((oldsize+1)*sizeof(off_t)))==NULL) ||
    ((V=malloc((oldsize+1)*sizeof(off_t)))==NULL)) err(1,NULL);

-- 
You are receiving this mail because:
You are the assignee for the bug.