From owner-freebsd-fs@FreeBSD.ORG Mon Apr 29 10:51:44 2013 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id BC7A4992 for ; Mon, 29 Apr 2013 10:51:44 +0000 (UTC) (envelope-from jdc@koitsu.org) Received: from qmta07.emeryville.ca.mail.comcast.net (qmta07.emeryville.ca.mail.comcast.net [IPv6:2001:558:fe2d:43:76:96:30:64]) by mx1.freebsd.org (Postfix) with ESMTP id A28ED17D0 for ; Mon, 29 Apr 2013 10:51:44 +0000 (UTC) Received: from omta04.emeryville.ca.mail.comcast.net ([76.96.30.35]) by qmta07.emeryville.ca.mail.comcast.net with comcast id Vmrk1l0010lTkoCA7mrkm8; Mon, 29 Apr 2013 10:51:44 +0000 Received: from koitsu.strangled.net ([67.180.84.87]) by omta04.emeryville.ca.mail.comcast.net with comcast id Vmrj1l0091t3BNj8QmrjcB; Mon, 29 Apr 2013 10:51:44 +0000 Received: by icarus.home.lan (Postfix, from userid 1000) id 4E46173A1B; Mon, 29 Apr 2013 03:51:43 -0700 (PDT) Date: Mon, 29 Apr 2013 03:51:43 -0700 From: Jeremy Chadwick To: Steven Hartland Subject: Re: seeing data corruption with zfs trim functionality Message-ID: <20130429105143.GA1492@icarus.home.lan> References: <60316751643743738AB83DABC6A5934B@multiplay.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60316751643743738AB83DABC6A5934B@multiplay.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1367232704; bh=xOS5dMGiCw68TkvanQU6+ecDhIC1l+jRqvg0LYeCaw8=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=tUsKocLCGKMIjzKINCp1+ChJq15VSfitk1n8f/lteK7oNdj8DC3Ak32esyDx/Hhpz OCCPgC8RGX7CL3Fqf1XYOWcehuro6FmiKhBFKgFl2FchRT57QYAhT1fd/2nmRTdo20 PqgM5uwBWyOJwP6BcAOczVqZzPLK3B7TqSaR5aHYtPjEYu52pP810KxSikCe4bxLUn vQOIY0SHU0DzYjISnFbsXYzEcEMNNSUTKvdgFTHuspQpdBR3oL0BB+mg45PyBTNC+9 RS62yvASGVi2eD8zScCyqkttmyA1qx3pn69ijefjjcoPRTxc7GsLdmzKwofUmZV2eQ SFu+hyQW9Eb7g== Cc: freebsd-fs@freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Apr 2013 10:51:44 -0000 On Mon, Apr 29, 2013 at 09:22:06AM +0100, Steven Hartland wrote: > ----- Original Message ----- From: "Ajit Jain" > > > >I am running zfs with trim functionality (ported from head). Seeing data > >corruption when running iotest* with multiple threads (never saw data > >corruption with single thread). > > > >The patches merged to add trim support are as follows: > >1. 240868 (zfs trim patch) > >2. 230053 and 245252 (block device driver trim support) > >3. 239655 (fix an issue in patch 230053) > > > >I am "NOT" seeing data corruption in the following cases: > >1. Running iotest with single thread (Trim is enabled at entire io stack). > >2. Trim is enabled at zfs layer but disable at driver layer i.e. delete > >method is set to NONE (even with multiple threads). > > > > > >Since patch 240868 alone was not working as I pulled in additional zfs trim > >patches 244155, 244187, 244188, 248572 (however I am not using separate > >L2arc device), 248573, 248574, 248575 and 248576. Still I am seeing the > >same issue. > > > >Issue: After some time running with multiple thread write system call > >return sometimes with EIO or 122 (checksum error) error code. > > > >I looked at GEOM code a bit I think it already has the trim (DELETE) > >command support. Still I am doubtful if I have pulled in all required > >patches in the entire I/O stack. > > > >I am using a LSI SAS HBA card to connect to the SSD, firmware seems to > >claim the support for trim. > > > >*iotest: non standard freebsd FreeBSD utility, which creates files and does > >I/O on the files and can be invoked in single/multithread mode to do the > >I/O. > > What version are you porting the changes to? > > What SSD are you using? > > What LSI controller are you using? I'd also like to see "zpool status" (for every pool that involves this SSD) and "gpart show" against the disk itself. -- | Jeremy Chadwick jdc@koitsu.org | | UNIX Systems Administrator http://jdc.koitsu.org/ | | Mountain View, CA, US | | Making life hard for others since 1977. PGP 4BD6C0CB |