From owner-svn-src-all@FreeBSD.ORG Mon Jun 29 09:56:59 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2E5311065697 for ; Mon, 29 Jun 2009 09:56:59 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 8C1B38FC25 for ; Mon, 29 Jun 2009 09:56:58 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 26168 invoked from network); 29 Jun 2009 09:43:15 -0000 Received: from localhost (HELO [127.0.0.1]) ([127.0.0.1]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 29 Jun 2009 09:43:15 -0000 Message-ID: <4A488FED.5040300@freebsd.org> Date: Mon, 29 Jun 2009 11:57:01 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.14 (Windows/20071210) MIME-Version: 1.0 To: Robert Watson References: <200906222308.n5MN856I055711@svn.freebsd.org> <4A47CC93.5090908@gmx.de> <4A486C20.2030307@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Christoph Mallon , src-committers@freebsd.org Subject: Re: svn commit: r194672 - in head/sys: kern netinet sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2009 09:56:59 -0000 Robert Watson wrote: > > On Mon, 29 Jun 2009, Andre Oppermann wrote: > >>> It seems either the third "if" is redundant (because the condition of >>> first "if" implies the condition of the third) or one of the >>> conditions is wrong. Also there should be spaces around the |. >> >> Thank you for the report. I'm working on fixing and testing all the >> issues that were raised in the perforce branch to be committed soon >> after review. > > I'd really like to see soreceive_stream() grow support for control > mbufs, if only by detecting controlp != NULL and calling > soreceive_generic(), and having the mtouio routing properly detect and > free them. This would allow us to use soreceive_stream() with UNIX > domain stream sockets, which are used by MySQL and see similar > performance issues. I'm trying to integrate that. My more detailed response to you is still pending. I have it open in one window as a reference to work all the issues. -- Andre