From owner-freebsd-multimedia@FreeBSD.ORG Fri Jan 16 15:30:05 2009 Return-Path: Delivered-To: freebsd-multimedia@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F23A81065727 for ; Fri, 16 Jan 2009 15:30:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 0E7EB8FC26 for ; Fri, 16 Jan 2009 15:30:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n0GFU4aG020218 for ; Fri, 16 Jan 2009 15:30:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n0GFU49J020217; Fri, 16 Jan 2009 15:30:04 GMT (envelope-from gnats) Date: Fri, 16 Jan 2009 15:30:04 GMT Message-Id: <200901161530.n0GFU49J020217@freefall.freebsd.org> To: freebsd-multimedia@FreeBSD.org From: bf Cc: Subject: Re: ports/127468: [PATCH]audio/wavpack: update to 4.50.1 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: bf List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jan 2009 15:30:08 -0000 The following reply was made to PR ports/127468; it has been noted by GNATS. From: bf To: Christian Weisgerber Cc: bug-followup@FreeBSD.org Subject: Re: ports/127468: [PATCH]audio/wavpack: update to 4.50.1 Date: Fri, 16 Jan 2009 07:20:10 -0800 (PST) --- On Wed, 1/14/09, Christian Weisgerber wrote: ... > > I tried building wavpack with MMX support on 6.4/i386, but > cc aborts > with an internal compiler error there. > That's too bad. Do you have a build log? If so, I'd be interested to see it. Did you send it to the upstream maintainers? > > Therefore I think that this build option > > should be exposed in the port Makefile, > > whether in an OPTION or just a simple > > knob, off by default. > > Well, we'll have to figure out where it _can_ be > enabled. > > 6.x 7.x 8.x > i386 no yes ? > amd64 ? ? yes > > Care to check the rest of the matrix? > > (This is why I'm not happy with such knobs. The effort > of supporting > them snowballs beyond the gain they offer.) > I admire your thoroughness, but I think you're making it too hard for yourself: I don't see the need to map all of this out now. With a non-default knob, I think we can expect (and probably will receive) help from users trying it on their systems, and it won't affect the package building cluster. I can tell you it definitely works on 8.x i386, because that's what I'm using. If you want to err on the side of caution, you could use something like: .ifdef(WITH_MMX) .if ( ${ARCH} == "i386" && ${OSVERSION} >= 700000 ) CONFIGURE_ARGS+= --enable-mmx post-patch: @${ECHO_MSG} "" @${ECHO_MSG} " You have chosen to enable the use of MMX intrinsics to " @${ECHO_MSG} " accelerate the encoding of high resolution ( > 16 bits- " @${ECHO_MSG} " per-sample ) data. Support for this non-default build " @${ECHO_MSG} " option will be at the discretion of individual committers. " @${ECHO_MSG} " Please submit bug reports to the upstream maintainers. " @${ECHO_MSG} "" .else IGNORE = option WITH_MMX is for i386 on FreeBSD >= 7 only .endif #ARCH, etc. .else CONFIGURE_ARGS+= --disable-mmx .endif #WITH_MMX Otherwise, you could contact someone with a tinderbox, or turn it on temporarily and throw it to the build cluster to get error logs. Regards, b.