From owner-cvs-src@FreeBSD.ORG  Mon Jan 29 05:15:08 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D59BD16A400
	for <cvs-src@freebsd.org>; Mon, 29 Jan 2007 05:15:08 +0000 (UTC)
	(envelope-from nate@root.org)
Received: from root.org (root.org [67.118.192.226])
	by mx1.freebsd.org (Postfix) with ESMTP id 8B1D413C467
	for <cvs-src@freebsd.org>; Mon, 29 Jan 2007 05:15:08 +0000 (UTC)
	(envelope-from nate@root.org)
Received: (qmail 39873 invoked from network); 29 Jan 2007 05:15:10 -0000
Received: from ppp-71-139-39-138.dsl.snfc21.pacbell.net (HELO ?10.0.5.59?)
	(nate-mail@71.139.39.138)
	by root.org with ESMTPA; 29 Jan 2007 05:15:10 -0000
Message-ID: <45BD82D2.20301@root.org>
Date: Sun, 28 Jan 2007 21:14:58 -0800
From: Nate Lawson <nate@root.org>
User-Agent: Thunderbird 1.5.0.9 (Windows/20061207)
MIME-Version: 1.0
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
References: <20070128202917.5B67916A5A6@hub.freebsd.org>
In-Reply-To: <20070128202917.5B67916A5A6@hub.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/geom/eli g_eli.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jan 2007 05:15:08 -0000

Pawel Jakub Dawidek wrote:
> pjd         2007-01-28 20:29:12 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/geom/eli         g_eli.c 
>   Log:
>   It is possible that GEOM taste provider before SMP is started.
>   We can't bind to a CPU which is not yet on-line, so add code that wait for
>   CPUs to go on-line before binding to them.
>   
>   Reported by:    Alin-Adrian Anton <aanton@spintech.ro>
>   MFC after:      2 weeks
>   
>   Revision  Changes    Path
>   1.34      +7 -0      src/sys/geom/eli/g_eli.c
> 
> 
> Index: src/sys/geom/eli/g_eli.c
> diff -u src/sys/geom/eli/g_eli.c:1.33 src/sys/geom/eli/g_eli.c:1.34
> --- src/sys/geom/eli/g_eli.c:1.33	Thu Nov  2 09:01:34 2006
> +++ src/sys/geom/eli/g_eli.c	Sun Jan 28 20:29:12 2007
> @@ -324,6 +324,13 @@
>  
>  	wr = arg;
>  	sc = wr->w_softc;
> +#ifdef SMP
> +	/* Before sched_bind() to a CPU, wait for all CPUs to go on-line. */
> +	if (sc->sc_crypto == G_ELI_CRYPTO_SW && g_eli_threads == 0) {
> +		while (!smp_started)
> +			tsleep(wr, 0, "geli:smp", hz / 4);
> +	}
> +#endif
>  	mtx_lock_spin(&sched_lock);
>  	sched_prio(curthread, PRIBIO);
>  	if (sc->sc_crypto == G_ELI_CRYPTO_SW && g_eli_threads == 0)

I thought tsleep() didn't work right before !cold.  Is that old knowledge?

-- 
Nate