From owner-svn-src-all@freebsd.org Sun Mar 5 00:35:30 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B322CEC4BF; Sun, 5 Mar 2017 00:35:30 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail109.syd.optusnet.com.au (mail109.syd.optusnet.com.au [211.29.132.80]) by mx1.freebsd.org (Postfix) with ESMTP id EBAED11F7; Sun, 5 Mar 2017 00:35:29 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from besplex.bde.org (c122-106-153-191.carlnfd1.nsw.optusnet.com.au [122.106.153.191]) by mail109.syd.optusnet.com.au (Postfix) with ESMTPS id 7D6F8D64ED0; Sun, 5 Mar 2017 11:35:27 +1100 (AEDT) Date: Sun, 5 Mar 2017 11:35:26 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Konstantin Belousov cc: John Baldwin , Pedro Giffuni , Slawa Olhovchenkov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314669 - head/sys/i386/conf In-Reply-To: <20170304231822.GA30979@kib.kiev.ua> Message-ID: <20170305111842.K1472@besplex.bde.org> References: <201703041504.v24F4HMh023937@repo.freebsd.org> <20170304211611.GW2092@kib.kiev.ua> <1951800.W2d2k3eamI@ralph.baldwin.cx> <20170304231822.GA30979@kib.kiev.ua> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=VbSHBBh9 c=1 sm=1 tr=0 a=Tj3pCpwHnMupdyZSltBt7Q==:117 a=Tj3pCpwHnMupdyZSltBt7Q==:17 a=kj9zAlcOel0A:10 a=NQkPwhnM_KHT0HcVA2YA:9 a=cB3OLWhqKwzjs8TJ:21 a=NSmHd3I7PG6UZQw2:21 a=CjuIK1q_8ugA:10 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Mar 2017 00:35:30 -0000 On Sun, 5 Mar 2017, Konstantin Belousov wrote: > On Sat, Mar 04, 2017 at 02:54:56PM -0800, John Baldwin wrote: >> On Saturday, March 04, 2017 11:16:11 PM Konstantin Belousov wrote: >>> On Sat, Mar 04, 2017 at 03:49:52PM -0500, Pedro Giffuni wrote: >>>> The number came out from an old posting involving buildworld times, which I can???t find now :(. >>>> Things seem to have changed a lot: it was surely using GCC back then, I don???t believe clang does much distinction about 486 at all. >>>> >>>> BTW, does it make sense to keep i586 in the configuration still? Both i486 and i586 were once removed but later re-instated in r205336. >>>> >>> What did make significant impact on 32bit shared libraries some time ago >>> was to compile them with -mtune=i686. Default PIC prologue effectively >>> neutered return stack predictor, adding uneccessary overhead to already >>> expensive PIC code. I think that this is even measureable, i.e. it might >>> give >= 5% of difference. I now use -mtune=athlon-xp (and no other -m CFLAGS) to get the same effect with minor additional optimizations/pessimizations for athlon-xp. I forget if I switched to this before or after getting jhb to not use -mtune=pentiumpro. Maybe we didn't know at the time that the pentiumpro optimizations affected little more than this PIC problem. >>> I did not rechecked modern compilers WRT the generated PIC code, but I doubt >>> that the thing changed recently. >>> >>> Several notes: -mtune is not -march, i.e. the code would be still targeted >>> for 486 instruction set, but scheduling is optimized for more modern CPUs. >>> Also, recent gcc puts specific meaning into -mtune=i686, interpreting it >>> as request for scheduling for generic modern CPUs. We already compile >>> 32bit compat libs on amd64 with -march=i686. >>> >>> Working on this stuff would be much more useful than tweaking kernel config >>> for CPU detection. >> >> Hmm, I originally wanted to use -mtune=i686 (spelled as -mcpu=pentiumpro) on >> i386 builds for this reason, but I removed it at bde@'s request in r125252. >> I would be happy to go back to adding -mtune for i386 when CPUTYPE isn't >> specified. > > I just rechecked. > gcc, at least 4.9 and 6.3, generate 'right' prologue, i.e. > call __x86.get_pc_thunk.cx (ecx or whatever register > which is used to address GOT) > __x86.get_pc_thunk.cx: > movl (%esp), %ecx > ret > even when compiling for -march=i486. > > OTOH, clang 3.9.1 uses > calll .L0 > .L0: popl %eax > to get the base even for native nehalem and newer CPUs. > > So indeed there is no reason to bother. gcc become too good to require any > tuning, and clang generates unoptimal code even when hinted. I did not > checked 4.0. The old method might actually be best for the original i386. It is 1 byte larger per call, but 1 instruction shorter by dynamic count. Original i386 has poor instruction fetch bandwidth and no caches and to help or harm. Even the (%esp) address mode can cost a cycle on original i386, and setting up a frame pointer to access the stack would be much worse, while on modern x86 the frame pointer might cost nothing since it can be done in parallel. Maybe some newer CPUs have better return address predictors so the old method is best for them too. It is only clear that generic optimizations should use the new method, since CPU manufacturers won't pessimize it since it looks like a normal function call. Bruce