Date: Fri, 4 May 2012 11:39:33 -0700 From: Jason Helfman <jgh@FreeBSD.org> To: Michael Scheidell <scheidell@FreeBSD.org> Cc: crees@freebsd.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/audio/teamspeak3-server Makefile distinfo pkg-plist ports/audio/teamspeak3-server/files pkg-message.in teamspeak.in Message-ID: <20120504183933.GE4992@dormouse.experts-exchange.com> In-Reply-To: <201205041826.q44IQDl7009239@repoman.freebsd.org> References: <201205041826.q44IQDl7009239@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 04, 2012 at 06:26:13PM +0000, Michael Scheidell thus spake: >scheidell 2012-05-04 18:26:13 UTC > > FreeBSD ports repository > > Modified files: > audio/teamspeak3-server Makefile distinfo pkg-plist > audio/teamspeak3-server/files pkg-message.in teamspeak.in > Log: > - Update to 3.0.3 [1] > - Update LICENSE_PERMS [1] > - Add @exec's to pkg-plist since Makefile:post-install isn't run with pkg-add [2] > - Add BATCH check because you can't acctept license in batch mode [3] > - Change mkdir/chown in Makefile (and pkg-plist) to install [3] > > PR: ports/166654 [1] http://www.FreeBSD.org/cgi/query-pr.cgi?pr=166654 > Submitted by: Richard Hirner <hirner@bitfire.at> (maintainer) [1] > Submitted by: scheidell (me) [2] > Submitted by: crees@ [3] > > Revision Changes Path > 1.22 +18 -8 ports/audio/teamspeak3-server/Makefile > 1.13 +4 -4 ports/audio/teamspeak3-server/distinfo > 1.4 +1 -1 ports/audio/teamspeak3-server/files/pkg-message.in > 1.3 +4 -4 ports/audio/teamspeak3-server/files/teamspeak.in > 1.10 +11 -3 ports/audio/teamspeak3-server/pkg-plist > >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/teamspeak3-server/Makefile.diff?&r1=1.21&r2=1.22&f=h >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/teamspeak3-server/distinfo.diff?&r1=1.12&r2=1.13&f=h >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/teamspeak3-server/files/pkg-message.in.diff?&r1=1.3&r2=1.4&f=h >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/teamspeak3-server/files/teamspeak.in.diff?&r1=1.2&r2=1.3&f=h >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/teamspeak3-server/pkg-plist.diff?&r1=1.9&r2=1.10&f=h > post-install is run with pkg-add, but it depends how it is used in the port. It could be done through Makefile/pkg-install script, or in the pkg-plist. Regardless, the user and group framework already takes care of adding users/groups in packaging and through ports, so the lines adding the users/groups to the packaging list and Makefile aren't necessary. Beyond this, the USERS and GROUPS aren't needed in the PLIST_SUB. If testing this showed otherwise, I would like to see it, as I have not seen any recent breakage of this kind. Either way, thanks for your time, and the update, eventhough I don't use it. :) -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120504183933.GE4992>