From owner-freebsd-current@FreeBSD.ORG  Thu Nov  8 22:28:29 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 50C29ECE;
 Thu,  8 Nov 2012 22:28:29 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net
 [IPv6:2001:7b8:2ff:146::2])
 by mx1.freebsd.org (Postfix) with ESMTP id 0BE028FC0A;
 Thu,  8 Nov 2012 22:28:29 +0000 (UTC)
Received: from [192.168.0.6] (spaceball.home.andric.com [192.168.0.6])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id 7E8345C59;
 Thu,  8 Nov 2012 23:28:27 +0100 (CET)
Message-ID: <509C320C.6010504@FreeBSD.org>
Date: Thu, 08 Nov 2012 23:28:28 +0100
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Andriy Gapon <avg@FreeBSD.org>
Subject: Re: [head tinderbox] failure on amd64/amd64
References: <201211081731.qA8HVbrV092796__9933.24017986215$1352395930$gmane$org@freebsd-current.sentex.ca>
 <509BF051.7030707@FreeBSD.org>
In-Reply-To: <509BF051.7030707@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: current@FreeBSD.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Nov 2012 22:28:29 -0000

On 2012-11-08 18:48, Andriy Gapon wrote:
> on 08/11/2012 19:31 FreeBSD Tinderbox said the following:
>> cc -c -O2 -pipe -fno-strict-aliasing  -std=c99  -Wall -Wredundant-decls
>> -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith
>> -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions
>> -Wmissing-include-dirs -fdiagnostics-show-option
>> -Wno-error-tautological-compare -Wno-error-empty-body
>> -Wno-error-parentheses-equality -nostdinc  -I. -I/src/sys
>> -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include
>> opt_global.h -DGPROF -DGPROF4 -DGUPROF -fno-builtin -fno-omit-frame-pointer
>> -mno-aes -mno-avx -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float
>> -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -Werror -pg
>> /src/sys/dev/aac/aac_debug.c /src/sys/dev/aac/aac_debug.c:163:8: error: format
>> string is not a string literal (potentially insecure)
>> [-Werror,-Wformat-security] panic(reason); ^~~~~~ 1 error generated. ***
>> [aac_debug.o] Error code 1
>
>
> I think that clang complaint is rightful here.
> But the tinderbox errors that we are getting after switch make me wonder if more
> preparations should have been done before the switch to make the transition smoother.

Yes, clang has been in the tree for almost two years now.  Why didn't
the *maintainers* of these drivers fix the warnings already? ;-)

Jokes aside, I am perfectly happy to go through these warnings, and fix
them.  But that requires a feedback cycle from the driver maintainers,
so it will take a while.  That is the disadvantage of the process we are
using.