From nobody Sat Mar 19 17:02:41 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 171A61A1B741; Sat, 19 Mar 2022 17:03:17 +0000 (UTC) (envelope-from thomas.e.zander@googlemail.com) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KLRz8727mz4TGx; Sat, 19 Mar 2022 17:03:16 +0000 (UTC) (envelope-from thomas.e.zander@googlemail.com) Received: by mail-wr1-f54.google.com with SMTP id q8so4179427wrc.0; Sat, 19 Mar 2022 10:03:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ya6FCIzpK8xxr5mdRe3g5cH7Ar8r/50nx2L02QzguBw=; b=jKJWJUTSC2E/CQQkvL4vu5YWeEvY7zQ0s6UjCx2ZX1Qgl7vEbWjqHuuwSXw/BRFcoR wC04M6pWG67DEauT5KX7Bm8AHgkXZFiua1wTlnZnORm2FAKi+/HiMZZiD/VmBEQBb82q 2/hT9NUi6TMAkym8WxWLpg+51tEI4MEiQkGJr8WnxF+Y2xfTphK6MFVoJNk2RChYsXre 1o3oDEfqXMfQgLQrIB+/QM0ZA33lq+3/gcHNuRII53fUJddoeHCbSPb206S8fs1ZZ59q 1PcX9BlH99gkNm5THQ6+2V+l1XdU3iWZokVYxuCsj+1KxpZ41LmCxqfbKJtrDQAogOOp /YSA== X-Gm-Message-State: AOAM530elW5TC7mhF7MgUsrtMp+dWRpxo3bUn+IEqztOna49rQ3HaJly On2anKOr1B7eS9FLXsLDZ0jUfgYC1XfI71Q3zsf3M1Yd2rwtTw== X-Google-Smtp-Source: ABdhPJyVRYoTya7PschuvuLPH7EaLZ1Hd/QZRCVjZZ9dHJv4jt/g5qT/R4QJTx/mh2deniOBxY4bmaw25lB3G1jIKTk= X-Received: by 2002:adf:ebc7:0:b0:1ee:945a:ffb4 with SMTP id v7-20020adfebc7000000b001ee945affb4mr12567299wrn.641.1647709390168; Sat, 19 Mar 2022 10:03:10 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <579f562b-8add-d3f7-77c9-1a6126bd282b@FreeBSD.org> In-Reply-To: From: Thomas Zander Date: Sat, 19 Mar 2022 18:02:41 +0100 Message-ID: Subject: Re: git: 43741377b143 - main - security/openssl: Security update to 1.1.1n To: Mark Johnston Cc: Rene Ladan , Matthias Fechner , Christoph Moench-Tegeder , Bernard Spil , "ports-committers@FreeBSD.org" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, FreeBSD Security Team Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4KLRz8727mz4TGx X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N It's probably not a specific port that allows it to reproduce. I have seen the problem locally (Xeon Sandy Bridge) on the png and python38 ports. I also could reproduce the problem on an Azure VM, instance type "Standard D4as v4" (AMD EPYC 7452), so it does not seem to be limited to a particular microarchitecture. On Sat, 19 Mar 2022 at 17:43, Mark Johnston wrote: > > On Sat, Mar 19, 2022 at 12:40:45PM +0100, Thomas Zander wrote: > > On Sat, 19 Mar 2022 at 12:11, Rene Ladan wrote: > > > > > > On Sat, Mar 19, 2022 at 11:04:58AM +0100, Thomas Zander wrote: > > > > On Sat, 19 Mar 2022 at 09:00, Matthias Fechner wrote: > > > > > > > > > I can confirm now, the problem is definitely related to the -p8 update. > > > > > I rolled back now to -p7 using `freebsd-update rollback`. > > > > > [...] > > > > > System is now up and running again. > > > > > This all works even if poudriere jail is using -p8. No need to downgrade the jail/base version poudriere is using. > > > > > It is caused by the kernel so the ZFS patch seems to be broken and -p8 should maybe not rolled out to not break more systems of users. > > > > > > > > On top of "stop rollout", there is the question how to identify the > > > > broken files for the users who have already upgraded to -p8. A `zpool > > > > scrub` presumably won't help. > > > > > > I think it also applies to 13.1-BETA2 ? > > > > > > Should we involve/CC some src committers? > > > > I have just rolled back to -p7 and run a number of test builds in > > poudriere (the jails still have the -p8 user land). I see the same as > > Matthias and Christoph, the rollback to the -p7 kernel/zfs resolved > > the build problems, there are no NUL byte files generated anymore. > > Adding markj@ to the discussion. Mark, the TLDR so far: > > - One of the zfs patches in -p8 seems to cause erroneous writes. > > - We noticed because of many build failures with poudriere (presumably > > highly io-loaded during build). > > - Symptom: Production of files with large runs of NUL-bytes. > > I've had zero luck reproducing this locally. I built several hundred > ports, including textproc/py-pystemmer mentioned elsewhere in the > thread, without any failures or instances of zero-filled files. Another > member of secteam also hasn't been able to trigger any build failures on > -p8. Any hints on a reproducer would be useful. > > We can simply push a -p9 which reverts EN-22:10 and :11, but of course > it would be preferable to precisely identify the problem.