From owner-svn-src-head@FreeBSD.ORG  Fri May  3 20:54:54 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 8D9BC4B2;
 Fri,  3 May 2013 20:54:54 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 by mx1.freebsd.org (Postfix) with ESMTP id 6A4A613BA;
 Fri,  3 May 2013 20:54:54 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 914E8B945;
 Fri,  3 May 2013 16:54:53 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Konstantin Belousov <kostikbel@gmail.com>
Subject: Re: svn commit: r250193 - head/sys/fs/msdosfs
Date: Fri, 3 May 2013 16:50:12 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; )
References: <201305022000.r42K0Bdk098965@svn.freebsd.org>
 <201305031155.47559.jhb@freebsd.org> <20130503203541.GS3047@kib.kiev.ua>
In-Reply-To: <20130503203541.GS3047@kib.kiev.ua>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201305031650.12397.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Fri, 03 May 2013 16:54:53 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 May 2013 20:54:54 -0000

On Friday, May 03, 2013 4:35:41 pm Konstantin Belousov wrote:
> On Fri, May 03, 2013 at 11:55:47AM -0400, John Baldwin wrote:
> > On Thursday, May 02, 2013 4:00:11 pm Konstantin Belousov wrote:
> > > Author: kib
> > > Date: Thu May  2 20:00:11 2013
> > > New Revision: 250193
> > > URL: http://svnweb.freebsd.org/changeset/base/250193
> > > 
> > > Log:
> > >   The fsync(2) call should sync the vnode in such way that even after
> > >   system crash which happen after successfull fsync() return, the data
> > >   is accessible.  For msdosfs, this means that FAT entries for the file
> > >   must be written.
> > >   
> > >   Since we do not track the FAT blocks containing entries for the
> > >   current file, just do a sloppy sync of the devvp vnode for the mount,
> > >   which buffers, among other things, contain FAT blocks.
> ...
> 
> > Does this fix kern/62762?
> > 
> 
> Supposedly yes, I even possibly have seen this PR before.
> At least, it is understandable why do you remember about it now.
> 
> I definitely do not want to take the approach of precisely calculating
> the list of FAT blocks which needs to be synced.

No, that seems too painful.

-- 
John Baldwin