Date: Wed, 21 Jan 2004 16:38:58 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Sergey Skvortsov <skv@protey.ru>, perl@FreeBSD.org Subject: Re: requst for review: PR/61621 Message-ID: <528419787.1074703138@andromede.reaumur.absolight.net> In-Reply-To: <400E9591.8040109@protey.ru> References: <400D4EE6.8010003@FreeBSD.org> <447910631.1074622626@andromede.reaumur.absolight.net> <400E4909.5020309@FreeBSD.org> <5310937.1074682561@pouet.in.mat.cc> <400E9591.8040109@protey.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========407E2811D1D105CDD17B========== Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline +-le 21/01/2004 18:06 +0300, Sergey Skvortsov =E9crivait : | Mathieu Arnold wrote: |> |> They are the only ones needed, and I've not seen yet a modules that |> |> only comes with only a Build.PL and no passthrough Makefile.PL. |> |=20 |> | There is no guarantee. |> | And I suppose building modules via Module::Build has some advantages. |>=20 |> Well, the Makefile.PL are just passthrough that run perl Build.PL, and |> generate a makefile that will call perl Build. When I started with M::B, |> I redefined do-build and do-install... But I felt it easier to maintain |> to just use the passthrough Makefile. You're right, there is no |> guarantee that it will always be, but it has been so far :) |=20 | This patch is intended to naturally support Module::Build-driven ports. Yes, I quite see that :) Bear in mind that when I started, M::B interface was still changing a lot, and it was easyer just to use the Makefile.PL passthrough. | The next step - move all perl-related stuff into bsd.perl.mk. | So the minimization of handling logic is not so important. | And all new logic also will be moved into new .mk That sounds really good, I've been thinking about something like that for some time now. |> And you should define ALL_TARGET?=3D build so that it has a resonable |> default I guess. |=20 | Empty target also works. It would tell people what the default target should be in case they want to do as they do for regular perl ports ALL_TARGETS=3D"all test" they'll know that it's not "all" but "build". |> And, you'll have to account for M::B build process, it should use |> PERL_MODBUILD=3Dyes, but it should not depend on M::B, or it'll kinda = loop |> :) |=20 | p5-Module-Build should use usual "PERL_CONFIGURE" and redefine | do-(build|install). |=20 | Special check for portname 'p5-Module-Build' in bsd.port.mk is overkill | and must be avoided. That would lead to code dupplication, I don't believe it's good, but well, if you think it's better this way :) --=20 Mathieu Arnold --==========407E2811D1D105CDD17B========== Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (MingW32) iD8DBQFADp0UqYYpzGz/vmcRAhRhAKCdFutp+VNVT7N181mTNYhHAgnvCACffdm7 9RQhaRNeaxMRn4Vua0ro77s= =JToD -----END PGP SIGNATURE----- --==========407E2811D1D105CDD17B==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?528419787.1074703138>