From owner-svn-src-head@freebsd.org Tue Dec 1 17:52:12 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B695A3EA79; Tue, 1 Dec 2015 17:52:12 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x235.google.com (mail-ig0-x235.google.com [IPv6:2607:f8b0:4001:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5C97B1493; Tue, 1 Dec 2015 17:52:12 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by igvg19 with SMTP id g19so99812980igv.1; Tue, 01 Dec 2015 09:52:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=G21SFSw6Q5JDosv4T53BfOnIwrWkUUsaZX4abymzJn4=; b=oA1/BpDVoDfVC8AakoqVdzhVqHQHpb3UJkBwXrgsnrn65YY4D2u0L4awPoUi6r95vA 9AXP1L1fTKnSq9L8B/QrvMRuMLulA9XbuiyTWAulBGs0dePB6k5/XBDSYV4uniGxnGIs SpC2qE3netFhfivJl4Q6AgkF9VP24hZvU07MqlWfz308/wqkAKwOcy9uI/H+Xq9bVLPu JCph4M/3bm3sLWuoDPpqbolYIMtN19evgtIyLzv7McQncDTFaJPpPrEDqkD4kWfv0XuL xofxNyCI5eCSPJgyNWFqkstqvmIsuyr6zzOOZ2rB6azLcnCDvMwLqwGRfiAANsy6X/5L ylOQ== MIME-Version: 1.0 X-Received: by 10.50.6.36 with SMTP id x4mr25971821igx.61.1448992331800; Tue, 01 Dec 2015 09:52:11 -0800 (PST) Received: by 10.36.217.196 with HTTP; Tue, 1 Dec 2015 09:52:11 -0800 (PST) In-Reply-To: <565DDDA5.3040202@FreeBSD.org> References: <201512011738.tB1HcqMe029403@repo.freebsd.org> <565DDDA5.3040202@FreeBSD.org> Date: Tue, 1 Dec 2015 09:52:11 -0800 Message-ID: Subject: Re: svn commit: r291600 - in head: lib/lib80211 share/mk From: Adrian Chadd To: Bryan Drewery Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2015 17:52:12 -0000 oh, thanks! -a On 1 December 2015 at 09:49, Bryan Drewery wrote: > On 12/1/2015 9:38 AM, Bryan Drewery wrote: >> Author: bdrewery >> Date: Tue Dec 1 17:38:52 2015 >> New Revision: 291600 >> URL: https://svnweb.freebsd.org/changeset/base/291600 >> >> Log: >> Fix underlinking in lib80211 and define static dependencies in src.libnames.mk >> so NO_SHARED works properly. >> >> Reported by: Manfred Antar >> Sponsored by: EMC / Isilon Storage Division >> >> Modified: >> head/lib/lib80211/Makefile >> head/share/mk/src.libnames.mk >> >> Modified: head/lib/lib80211/Makefile >> ============================================================================== >> --- head/lib/lib80211/Makefile Tue Dec 1 17:31:22 2015 (r291599) >> +++ head/lib/lib80211/Makefile Tue Dec 1 17:38:52 2015 (r291600) >> @@ -8,6 +8,8 @@ SRCS= lib80211_regdomain.c lib80211_ioct >> INCSDIR= ${INCLUDEDIR}/lib80211 >> INCS= lib80211_regdomain.h lib80211_ioctl.h >> >> +LIBADD= sbuf bsdxml >> + > > I have a branch in progress to automatically detect underlinking like > this. I did so at Isilon for internal libraries, but not FreeBSD > libraries. Doing so for FreeBSD has become a massive effort just as it > was for Isilon's internal libraries. There's a lot of cyclic > dependencies and libraries missing from src.libnames.mk. > >> MAN= lib80211.3 >> >> CFLAGS+=-I${.CURDIR} >> >> Modified: head/share/mk/src.libnames.mk >> ============================================================================== >> --- head/share/mk/src.libnames.mk Tue Dec 1 17:31:22 2015 (r291599) >> +++ head/share/mk/src.libnames.mk Tue Dec 1 17:38:52 2015 (r291600) >> @@ -162,6 +162,7 @@ _LIBRARIES= \ >> ypclnt \ >> z >> >> +_DP_80211= sbuf bsdxml > > I am adding a sanity check in src.libnames.mk for this to assert that > the _DP_{lib} matches the lib's LIBADD. > > I consider the _DP_{lib} entries to be a bad hack but it's what we're > stuck with for now until something better comes along. > >> _DP_archive= z bz2 lzma bsdxml >> .if ${MK_OPENSSL} != "no" >> _DP_archive+= crypto >> > > > -- > Regards, > Bryan Drewery >