From owner-cvs-all Wed Feb 13 17:23:45 2002 Delivered-To: cvs-all@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id 8B6EE37B416; Wed, 13 Feb 2002 17:23:35 -0800 (PST) Received: by elvis.mu.org (Postfix, from userid 1192) id 3AE2110DDFF; Wed, 13 Feb 2002 17:23:35 -0800 (PST) Date: Wed, 13 Feb 2002 17:23:35 -0800 From: Alfred Perlstein To: Greg Lehey Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/conf GENERIC Message-ID: <20020213172335.C63886@elvis.mu.org> References: <200202131847.g1DIlp851160@freefall.freebsd.org> <20020213170750.B732@sydney.worldwide.lemis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020213170750.B732@sydney.worldwide.lemis.com>; from grog@FreeBSD.org on Wed, Feb 13, 2002 at 05:07:50PM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Greg Lehey [020213 17:08] wrote: > On Wednesday, 13 February 2002 at 10:47:51 -0800, Alfred Perlstein wrote: > > alfred 2002/02/13 10:47:51 PST > > > > Modified files: > > sys/i386/conf GENERIC > > Log: > > Re-enable WITNESS for GENERIC. Since the 5.x branch is mostly about > > SMP we'd like as much feedback as possible from users about possible > > locking problems as early as possible. > > Why did you do that when obviously rwatson disagreed? The correct > thing to do would have been to get a consensus first and give rwatson > the opportunity to back it out. Note that we definitely don't have a > consensus. > > > To negate most of the performance impact I've also enabled > > WITNESS_SKIPSPIN. I've done this as we've been running WITNESS > > over the spinlock code for a while without incident and it goes a > > long way to making the performance problems of WITNESS much more > > bearable. > > This might be a good compromise. But we need to agree first. This issue has been resolved, the WITNESS_SKIPSPIN stuff seems to have made people a bit more comfortable about it. -Alfred To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message