From owner-cvs-src@FreeBSD.ORG  Fri Apr  4 02:10:42 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 31E9B37B404; Fri,  4 Apr 2003 02:10:42 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8BBC243FB1; Fri,  4 Apr 2003 02:10:39 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id UAA04633;
	Fri, 4 Apr 2003 20:10:35 +1000
Date: Fri, 4 Apr 2003 20:10:34 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: "David O'Brien" <obrien@FreeBSD.org>
In-Reply-To: <20030403155917.GC17860@dragon.nuxi.com>
Message-ID: <20030404200159.J33842@gamplex.bde.org>
References: <200304030513.h335DR60079544@repoman.freebsd.org>
	<20030403055049.GA67232@dhcp01.pn.xcllnt.net>
	<20030403085350.GA37174@sunbay.com>
	<20030403155917.GC17860@dragon.nuxi.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: src-committers@FreeBSD.org
cc: Ruslan Ermilov <ru@FreeBSD.org>
cc: Juli Mallett <jmallett@FreeBSD.org>
cc: cvs-src@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Marcel Moolenaar <marcel@xcllnt.net>
Subject: Re: cvs commit: src/libexec/talkd announce.c extern.h print.ctable.c
 talkd.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Apr 2003 10:10:42 -0000

On Thu, 3 Apr 2003, David O'Brien wrote:

> On Thu, Apr 03, 2003 at 11:53:50AM +0300, Ruslan Ermilov wrote:
> > -.  if ${WARNS} > 4
> > +.  if ${WARNS} > 4 && !empty(CFLAGS:M-O*) && empty(CFLAGS:M-O0)
> >  CFLAGS		+=	-Wuninitialized
> >  .  endif
>
> Why not just get rid of it totally?  We have this already:

It's too useful to remove totally.

>     .  if ${WARNS} > 1 && ${WARNS} < 5
>     # XXX Delete -Wuninitialized by default for now -- the compiler doesn't
>     # XXX always get it right.
>     CFLAGS      +=  -Wno-uninitialized
>     .  endif
>
> so we already know it is problematic.  OR rather than use:
>
>     .  if ${WARNS} > 4
>     CFLAGS      +=  -Wuninitialized
>     .  endif
>
> use
>
>     .  if ${WARNS} == 4
>     CFLAGS      +=  -Wuninitialized
>     .  endif

Add -Wno-uninitialized to cancel -Wuninitialized being part of -Wall as
necessary, i.e., if -Wall is added (${WARNS} > 1) but -O is not in ${CFLAGS}.
Don't add it or change WARNS settings back and forth to work around bitrot
from -Wuninitialized not being turned off for so long.  Don't change sources
"to keep gcc happy".

Bruce