From owner-svn-src-projects@FreeBSD.ORG Fri Nov 14 18:17:38 2014 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7D609C14; Fri, 14 Nov 2014 18:17:38 +0000 (UTC) Received: from mail-pa0-x236.google.com (mail-pa0-x236.google.com [IPv6:2607:f8b0:400e:c03::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F2D7C57; Fri, 14 Nov 2014 18:17:38 +0000 (UTC) Received: by mail-pa0-f54.google.com with SMTP id hz1so6873757pad.27 for ; Fri, 14 Nov 2014 10:17:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=M18F5aGQcsan6SA0uXR9vHPoH9u+BN1fjH78i2Fz/+0=; b=H2FdA6jGYT5w9xmwCDk9+T2+jK2QUnHV5qJoOk4FHCMjwAzDTESoKUiscxsdz5kw7x QW3qShgF/fd9QETD+AIGYtVNzcq3/5NLbRuq33XLMSDAsW3FRVJjBNWDUxzVx8TsDS/L VrdLGLFE2Xey3jBkC3RUwctHF2iVq4uBo4SDBUAebeT+XM6mW9RYRdAYUxGABrjk3hj3 CnT8mlHgJLDISiYr1zKlgRoA5vTBCqXjN85q3tAW8YYqk+ZHwUzKe/B9TjLVWbjRJJ1a wq8NT8gyYgNp5vNl4Siif2qoGu43qnqebVHpkMa+DKdRctHG9+APlg59Ggr63pgDKDLw LgDA== X-Received: by 10.66.252.193 with SMTP id zu1mr3437267pac.153.1415989057679; Fri, 14 Nov 2014 10:17:37 -0800 (PST) Received: from ?IPv6:2601:8:ab80:7d6:d98b:3fe8:a14f:943? ([2601:8:ab80:7d6:d98b:3fe8:a14f:943]) by mx.google.com with ESMTPSA id fl2sm13159170pab.0.2014.11.14.10.17.36 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Nov 2014 10:17:37 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_E34CF5B8-E0D6-4D6A-8250-B049FC8B27A4"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r274517 - projects/sendfile/sys/vm From: Garrett Cooper In-Reply-To: <201411141801.sAEI1IWo066725@svn.freebsd.org> Date: Fri, 14 Nov 2014 10:17:35 -0800 Message-Id: References: <201411141801.sAEI1IWo066725@svn.freebsd.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Nov 2014 18:17:38 -0000 --Apple-Mail=_E34CF5B8-E0D6-4D6A-8250-B049FC8B27A4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Nov 14, 2014, at 10:01, Gleb Smirnoff wrote: > Author: glebius > Date: Fri Nov 14 18:01:18 2014 > New Revision: 274517 > URL: https://svnweb.freebsd.org/changeset/base/274517 >=20 > Log: > Use C99 "inline" keyword. >=20 > Modified: > projects/sendfile/sys/vm/vm_pager.h >=20 > Modified: projects/sendfile/sys/vm/vm_pager.h > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- projects/sendfile/sys/vm/vm_pager.h Fri Nov 14 18:00:00 2014 = (r274516) > +++ projects/sendfile/sys/vm/vm_pager.h Fri Nov 14 18:01:18 2014 = (r274517) > @@ -106,7 +106,7 @@ vm_object_t vm_pager_allocate(objtype_t, > void vm_pager_bufferinit(void); > void vm_pager_deallocate(vm_object_t); > static __inline int vm_pager_get_pages(vm_object_t, vm_page_t *, int, = int); > -static __inline int vm_pager_get_pages_async(vm_object_t, vm_page_t = *, int, > +static inline int vm_pager_get_pages_async(vm_object_t, vm_page_t *, = int, > int, void(*)(void *, int), void *); > static __inline boolean_t vm_pager_has_page(vm_object_t, vm_pindex_t, = int *, int *); > void vm_pager_init(void); > @@ -138,7 +138,7 @@ vm_pager_get_pages( > return (r); > } - What was wrong with using the "non-C99" constant? - Why not the other cases above that, e.g. vm_pager_get_pages? --Apple-Mail=_E34CF5B8-E0D6-4D6A-8250-B049FC8B27A4 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUZkc/AAoJEMZr5QU6S73eKtIH+wY7E247wiLCQ4tde1EVbh0Y zn+Xr18YFpm47YxQOYSkZ1cvBAtyBtPbD+QGKJQ2rPu5r3sgGYG8sqMXF+8l89U/ ADtkZ69KrFDBcPobbe5hqGET7PcOA8/b/gJmVPJpzkthtdkjiH6F5p79VQ3xKOJp 17cHjYk18b4+OvcYT5GHZyd4xWMXhsrIahV8aJmS/Uyk6fgG4XjNWbVvqh2642P9 +mgMNW1exh3kGws8A+Edk1B+tbOyFlMR1KSUjkwRROIgtoKqnyC3YEGC7qUT/dDV SXl28F5hKw4wWTcpU6olQrRXkX42Cge43yvI6ZJ/gIHl3EgABlxMRov7rRG9Zzc= =HcJY -----END PGP SIGNATURE----- --Apple-Mail=_E34CF5B8-E0D6-4D6A-8250-B049FC8B27A4--