From owner-svn-src-head@FreeBSD.ORG  Thu Nov 15 19:23:00 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 8054E279;
 Thu, 15 Nov 2012 19:23:00 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 by mx1.freebsd.org (Postfix) with ESMTP id EFB778FC12;
 Thu, 15 Nov 2012 19:22:59 +0000 (UTC)
Received: from tom.home (localhost [127.0.0.1])
 by kib.kiev.ua (8.14.5/8.14.5) with ESMTP id qAFJMtix077759;
 Thu, 15 Nov 2012 21:22:55 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.7.1 kib.kiev.ua qAFJMtix077759
Received: (from kostik@localhost)
 by tom.home (8.14.5/8.14.5/Submit) id qAFJMtQM077758;
 Thu, 15 Nov 2012 21:22:55 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Thu, 15 Nov 2012 21:22:55 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Eitan Adler <eadler@freebsd.org>
Subject: Re: svn commit: r243095 - head/sys/dev/agp
Message-ID: <20121115192255.GH73505@kib.kiev.ua>
References: <201211151849.qAFInHeU039083@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="jb7C7uZ/dsJO9et2"
Content-Disposition: inline
In-Reply-To: <201211151849.qAFInHeU039083@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Spam-Status: No, score=0.2 required=5.0 tests=ALL_TRUSTED,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 version=3.3.2
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Nov 2012 19:23:00 -0000


--jb7C7uZ/dsJO9et2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 15, 2012 at 06:49:17PM +0000, Eitan Adler wrote:
> Author: eadler
> Date: Thu Nov 15 18:49:17 2012
> New Revision: 243095
> URL: http://svnweb.freebsd.org/changeset/base/243095
>=20
> Log:
>   Remove unneeded header from agp: opt_bus.h
>  =20
>   Tested with "make universe"
make universe cannot prove anything about usefulness of the removed include,
just because *_opt.h files contains only defines, which are used later
by the code like
#ifdef OPTION
do something
#endif.

If you are removing the option include, the module Makefile should be
adjusted too.

--jb7C7uZ/dsJO9et2
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlClQQ4ACgkQC3+MBN1Mb4i6owCgwUAuPEipzaSOwc1NUeHOU4fO
FswAnRUD+STV1aDBlhQcz+WiGedJCmVQ
=g3Bd
-----END PGP SIGNATURE-----

--jb7C7uZ/dsJO9et2--