From owner-freebsd-ports@freebsd.org Tue Jul 24 09:50:35 2018 Return-Path: <owner-freebsd-ports@freebsd.org> Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0729110467BE for <freebsd-ports@mailman.ysv.freebsd.org>; Tue, 24 Jul 2018 09:50:35 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9B448882F9; Tue, 24 Jul 2018 09:50:34 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.128.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 486D92605D5; Tue, 24 Jul 2018 11:50:27 +0200 (CEST) Subject: Re: Request for commit approval : jack_umidi To: koobs@FreeBSD.org, FreeBSD Ports <freebsd-ports@freebsd.org> References: <89be83f1-6871-0420-964a-703448af5d00@selasky.org> <332f2182-972b-0e5d-251c-139f974428a9@FreeBSD.org> From: Hans Petter Selasky <hps@selasky.org> Message-ID: <97415ea2-264a-1bd9-4620-e8402f4ca0a3@selasky.org> Date: Tue, 24 Jul 2018 11:50:08 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <332f2182-972b-0e5d-251c-139f974428a9@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>, <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/> List-Post: <mailto:freebsd-ports@freebsd.org> List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>, <mailto:freebsd-ports-request@freebsd.org?subject=subscribe> X-List-Received-Date: Tue, 24 Jul 2018 09:50:35 -0000 On 07/24/18 11:44, Kubilay Kocak wrote: > On 24/07/2018 7:39 pm, Hans Petter Selasky wrote: >> Update jack_umidi to version 1.0.9 >> >> Fix for long device names. >> >> Approved by: >> >> --HPS >> > > Looks fine (syntactically), but hesitant to approve without QA > confirmation (poudriere, for packaging checks, etc) > > But since the pkg-plist is defined within Makefile *_PLIST entries and > assuming its contents have been checked to not have changed .. > > Approved: koobs (ports) > MFH: 2018Q3 (bugfix) Thank you! Should not break anything. --HPS