From owner-freebsd-hackers@freebsd.org Thu May 19 21:29:38 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7C7BB41B53 for ; Thu, 19 May 2016 21:29:38 +0000 (UTC) (envelope-from rwestlun@gmail.com) Received: from mail-qk0-x22f.google.com (mail-qk0-x22f.google.com [IPv6:2607:f8b0:400d:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 721A812A4; Thu, 19 May 2016 21:29:38 +0000 (UTC) (envelope-from rwestlun@gmail.com) Received: by mail-qk0-x22f.google.com with SMTP id n63so56263680qkf.0; Thu, 19 May 2016 14:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=h5FwQomijjwUanPR6/lEscsJEbKg1oNSaFdByz9r0ew=; b=dmGOXSqxbKJdIY/ikyu+zsCh/hVKW3X3240vEngNA10nsaPbt9btUMUG3QkiioAz0k mZ88w1W200DaLEheH7TG5YMaf/uQG90JsMZSZrrqI0bzxl+pxkn9AHWXkxOfICKQIk/A HW5BN3RG47bH+g8MXRwyexbFuUu7z2xzOxoIBfEVx9C8awxkDSmaasApDMt840yF7oww VkcXzczYmZdMNr9/zuhOpFiFz53JKRvxoBo7wEvtAxEEIx+/OGudMBQxtMJ68pW4H1Q8 1fXACArITr6l46nftl03qCYfU65jZcRZ2OW1vCHU7ynpgyT1A9UHj8WfjnhGJzR5CrGv 30Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=h5FwQomijjwUanPR6/lEscsJEbKg1oNSaFdByz9r0ew=; b=JZH0niwqwpS5NT7wJoDn1FpoXAt0UI64NyTViBI52nVwN8rHFkyv9zGWvS6F56sdp1 rYOSEm73tZLhelSEbdOm4+SpdyqX+xfda1Pqbdzh1D8xJoUYQW4Vg2M8SYo5I1rlRCKw nqeK3p+wp2KcibhFcnrR5y+1rd93laXyyakisRKI3c0B3Q5FRhONJab54MN/j4q+d/oV D083HX1SK3aEOUi4AosktT9/jPEJPwczlJEgCBgXWaI0vRjkzwo9MFSCHyZjoaSNglxI Em50kxLUP1LP5o2z6uWIh1rBw1uPOLZpIwuH7oiAuw0GpbeMeigR9l3anPWBIB9Mb3OH GLiA== X-Gm-Message-State: AOPr4FVDHTnbdoQVIBCI12mg4bhWH/o58Pl1atzKDA3DHtAkDcbGFeFsCiu/UfjOKdZdYA== X-Received: by 10.55.33.102 with SMTP id h99mr17333993qkh.130.1463693377557; Thu, 19 May 2016 14:29:37 -0700 (PDT) Received: from gmail.com (c-98-216-247-110.hsd1.ma.comcast.net. [98.216.247.110]) by smtp.gmail.com with ESMTPSA id i206sm7417436qhi.9.2016.05.19.14.29.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 May 2016 14:29:36 -0700 (PDT) Date: Thu, 19 May 2016 17:29:34 -0400 From: Randy Westlund To: Allan Jude Cc: freebsd-hackers@freebsd.org Subject: Re: What changes are welcome? Message-ID: <20160519212934.GF19887@gmail.com> References: <20160519041118.GE19887@gmail.com> <573D3DA7.20600@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ls2Gy6y7jbHLe9Od" Content-Disposition: inline In-Reply-To: <573D3DA7.20600@freebsd.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 21:29:38 -0000 --Ls2Gy6y7jbHLe9Od Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 19, 2016 at 12:14:31AM -0400, Allan Jude wrote: > Generally, you likely want to avoid changing anything from contrib/ or > vendor/, as that is code from other projects that is imported, and local > changes complicate that. Of course, top is not really maintained > 'upstream' anymore, so maybe it isn't a bad place to start. >=20 > Phabricator is likely the best place for patches, it is much easier to > review. Indeed, looks like it's been 16 years. I silenced 131 warnings. https://reviews.freebsd.org/D6468 --Ls2Gy6y7jbHLe9Od Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXPjA+AAoJEGaweXjzNsmpEAcH/0sjaMBC/YQIi2oNtbTknBar HuXsk+gW1ob4W/yQ74fk8LN5AKV8NlGfrnSece+057/QZDJMRBRWMHqQK9RumP+P GdGFwJdeX29SV+CURAnENfCS5Is+Nra08Amkk/4h6b71yK1YCMSfwHSDSs5/0y3R EXQCdtLvSoiqyFfbER84iM3udLKgnZy2hOyxXwXzjWNu8Fh1OFaoHOcM7Ofegj6r zDC7SZkFTgQHlVi6IyrgtziBMTRDo8sfsmIfeLtoGdZh1gnRFBI3ZEDxBVPTwArM EBSiLZhI3fE5BTwKUBqX/0LKZdm0JQKUqdTvK7oGkJROwRcgnq9lcBwVUnA60Pc= =KHCd -----END PGP SIGNATURE----- --Ls2Gy6y7jbHLe9Od--