From owner-svn-src-head@FreeBSD.ORG Mon May 18 00:54:06 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 26718762; Mon, 18 May 2015 00:54:06 +0000 (UTC) Received: from smtp-out-02.shaw.ca (smtp-out-02.shaw.ca [64.59.136.138]) by mx1.freebsd.org (Postfix) with ESMTP id C85BB14A6; Mon, 18 May 2015 00:54:05 +0000 (UTC) Received: from spqr.komquats.com ([24.68.119.200]) by shaw.ca with SMTP id u9JaY1cma7BFNu9JbY2ZZZ; Sun, 17 May 2015 18:53:58 -0600 X-Authority-Analysis: v=2.1 cv=D/qNUKlj c=1 sm=1 tr=0 a=DtyMuQCYAJf2vvIh/Mv8eA==:117 a=DtyMuQCYAJf2vvIh/Mv8eA==:17 a=BWvPGDcYAAAA:8 a=kj9zAlcOel0A:10 a=VxmjJ2MpAAAA:8 a=h1PgugrvaO0A:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=nw-bFE1efLBgUkvGWoEA:9 a=CjuIK1q_8ugA:10 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 8C5229BF6; Sun, 17 May 2015 17:53:54 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.14.9/8.14.9) with ESMTP id t4I0rsOR020656; Sun, 17 May 2015 17:53:54 -0700 (PDT) (envelope-from Cy.Schubert@komquats.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.14.9/8.14.8/Submit) with ESMTP id t4I0rqv4020640; Sun, 17 May 2015 17:53:52 -0700 (PDT) (envelope-from Cy.Schubert@komquats.com) Message-Id: <201505180053.t4I0rqv4020640@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.komquats.com/ To: Andrew Turner cc: Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r282415 - head/usr.sbin/ntp In-Reply-To: Message from Andrew Turner of "Sun, 17 May 2015 19:08:10 +0100." <20150517190810.4006b7bb@bender.Home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 17 May 2015 17:53:52 -0700 X-CMAE-Envelope: MS4wfL7bdrZoWHvivWZmMaglcGrSZaIv1VkxTdX+RAKfmTclpnnYwMW7vcSCuR+wsWuPS94mXi2S54D9wtB+iU8sdnxOnCDhW5QnTD0f8SVIdXePDv7UryxGZstcUnpbEMH9AqRFfYcESIoQliEUqb6SOPmVUEXr+tcRzdwfE8dCgS8qS8XZpBH11RVeXyoGVEjuTovMcPo+7tDJe6zS4skZCgSNSlYW6RyjodYY5wqI2eBiOG/J5mf+Po3n5OJrM7SwLHJbAZJbM+LdtTq8/Op9MirciKIy833LdIL+FKrEAZU63ueBkfsHWcNe87K2cPCYWQ== X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2015 00:54:06 -0000 In message <20150517190810.4006b7bb@bender.Home>, Andrew Turner writes: > On Mon, 4 May 2015 12:42:53 +0000 (UTC) > Cy Schubert wrote: > > > Author: cy > > Date: Mon May 4 12:42:52 2015 > > New Revision: 282415 > > URL: https://svnweb.freebsd.org/changeset/base/282415 > > > > Log: > > Restore CPU dependent compile time conditionals. > > > > MFC after: 1 month (with r281143 and r282408) > > Do you have any plans on fixing this before you MFC it? Specifically: > * sizeof(char *) == 8 on arm64, powerpc64, and mips64 > * sizeof(long) == 8 on arm64, powerpc64, and mips64 > * sizeof(time_t) == 8 on arm, arm64, powerpc64, mips, and mips64 > * STR_SYSTEM is incorrect on arm, arm64, powerpc64, mips, and mips64, > however this is now less broken as it was previously also broken on > i386, and sparc64. > > This change is only correct for amd64, i386, and sparc64. That is correct. > > I suspect all of the above will also be relevant on ia64. We still have > support in 10-STABLE for this so should be fixed before an MFC. We should support ia64 at least until it's no longer supported in -stable. > > I have heard reports that NTP is broken on some of the above platforms > so they don't keep very accurate time. Can you fix this, or revert this > change until a fix can be written. Unfortunately -stable is currently as broken as it is in -current. The quick fix is to add all supported platforms. The other unfortunate fact is that, scanning the tree for other examples there's more code as broken as this is. I propose: 1. Fix NTP -- I will do this. I have some free time coming up this week to focus on this. 2. Identify other parts of the tree needing a little love and either putting it up on the wiki or in phabricator. 3. Fix #2 (either me or others as we see fit). Alternatively, a common solution for all parts of the tree, if possible. This is probably a long term solution though. (The purist in me prefers this but I am practical too.) -- Cheers, Cy Schubert or FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.