From owner-svn-src-head@FreeBSD.ORG Wed Feb 25 19:42:29 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 40A8E106566B; Wed, 25 Feb 2009 19:42:29 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211]) by mx1.freebsd.org (Postfix) with ESMTP id CF2D78FC21; Wed, 25 Feb 2009 19:42:28 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: by palm.hoeg.nl (Postfix, from userid 1000) id 0C2EB1CDE5; Wed, 25 Feb 2009 20:42:28 +0100 (CET) Date: Wed, 25 Feb 2009 20:42:28 +0100 From: Ed Schouten To: Robert Noland Message-ID: <20090225194228.GS19161@hoeg.nl> References: <200902251854.n1PIsZZP005285@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MXxcbiX/Q4+iy5U7" Content-Disposition: inline In-Reply-To: <200902251854.n1PIsZZP005285@svn.freebsd.org> User-Agent: Mutt/1.5.19 (2009-01-05) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r189052 - head/sys/dev/drm X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Feb 2009 19:42:29 -0000 --MXxcbiX/Q4+iy5U7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Robert, * Robert Noland wrote: > +static struct drm_msi_blacklist_entry drm_msi_blacklist[] =3D { > + {0x8086, 0x2772}, /* Intel i945G */ \ > + {0x8086, 0x27A2}, /* Intel i945GM */ \ > + {0x8086, 0x27AE}, /* Intel i945GME */ \ > + {0, 0} > +}; Wouldn't it be better to use PCI_VENDOR_INTEL/PCI_PRODUCT_INTEL_* definitions here? --=20 Ed Schouten WWW: http://80386.nl/ --MXxcbiX/Q4+iy5U7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkmlnyMACgkQ52SDGA2eCwWvIQCfbuGlEs2h5aaoWDPFuJ+vTiQj a+gAn0a97CLRCyUAwikJHoDydtt8Xmeb =xKec -----END PGP SIGNATURE----- --MXxcbiX/Q4+iy5U7--