From owner-cvs-all Tue Jan 22 12:46:38 2002 Delivered-To: cvs-all@freebsd.org Received: from squall.waterspout.com (squall.waterspout.com [208.13.56.12]) by hub.freebsd.org (Postfix) with ESMTP id D440E37B416; Tue, 22 Jan 2002 12:46:23 -0800 (PST) Received: by squall.waterspout.com (Postfix, from userid 1050) id 6D65B9B74; Tue, 22 Jan 2002 15:46:03 -0500 (EST) Date: Tue, 22 Jan 2002 15:46:03 -0500 From: Will Andrews To: Maxim Sobolev Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/mail/evolution pkg-plist ports/mail/evolution/files patch-ac patch-camel::providers::local::Makefile.in patch-camel::providers::nntp::Makefile.in patch-camel::providers::pop3::Makefile.in patch-camel::providers::sendmail::Makefile.in patch-camel::providers::smtp::Makefile.in patch-mail::importers::Makefile.in Message-ID: <20020122154603.H18609@squall.waterspout.com> Reply-To: Will Andrews Mail-Followup-To: Maxim Sobolev , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200201222039.g0MKdcm91935@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200201222039.g0MKdcm91935@freefall.freebsd.org> User-Agent: Mutt/1.3.22.1i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Jan 22, 2002 at 12:39:37PM -0800, Maxim Sobolev wrote: > Revision Changes Path > 1.1 +14 -0 ports/mail/evolution/files/patch-camel::providers::local::Makefile.in (new) > 1.1 +14 -0 ports/mail/evolution/files/patch-camel::providers::nntp::Makefile.in (new) > 1.1 +14 -0 ports/mail/evolution/files/patch-camel::providers::pop3::Makefile.in (new) > 1.1 +14 -0 ports/mail/evolution/files/patch-camel::providers::sendmail::Makefile.in (new) > 1.1 +14 -0 ports/mail/evolution/files/patch-camel::providers::smtp::Makefile.in (new) > 1.1 +18 -0 ports/mail/evolution/files/patch-mail::importers::Makefile.in (new) Your patchfile names are needlessly long, IMO. For example, each of the above could have, instead, been: patch-local::Makefile.in patch-nntp::Makefile.in patch-pop3::Makefile.in patch-sendmail::Makefile.in patch-smtp::Makefile.in patch-importers::Makefile.in Also, your patchfiles can be easily replaced with a perl regex. -- wca To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message