From owner-cvs-src Thu Feb 13 14:31: 1 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF6D937B401; Thu, 13 Feb 2003 14:30:58 -0800 (PST) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8E04343FBD; Thu, 13 Feb 2003 14:30:58 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id 769DA2A8C1; Thu, 13 Feb 2003 14:30:58 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Eric Anholt Cc: Dag-Erling Smorgrav , Marcel Moolenaar , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules Makefile In-Reply-To: <1045175342.11981.1.camel@leguin> Date: Thu, 13 Feb 2003 14:30:58 -0800 From: Peter Wemm Message-Id: <20030213223058.769DA2A8C1@canning.wemm.org> Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Eric Anholt wrote: > On Thu, 2003-02-13 at 14:17, Peter Wemm wrote: > > The lines in agpreg.h were what Eric added after the fact. This is an > > i386-only chipset. It shouldn't have been in the sparc64, ia64, and alpha > > builds. It certainly shouldn't be in powerpc whenever we start doing > > builds for that. > > > > And IMHO, we certainly shouldn't be building/installing/releasing something > > that we *know* hard locks the machine (Drew's report on agp_amd.c locking > > up the UP1000). > > He said that he tried that when agp_amd first came out. agp_amd was > broken on that chipset for all architectures for some time. > > I am working on a patch to only build the appropriate stuff for each > arch. That would be much better. Please feel free to replace my hack. But please don't enable it on platforms that it doesn't work on. For example, we have: void agp_flush_cache() { #ifdef __i386__ wbinvd(); #endif } There's no alpha or ia64 support, so don't enable it there unless this cache flushing isn't needed. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message