Date: Thu, 13 Feb 2003 14:30:58 -0800 From: Peter Wemm <peter@wemm.org> To: Eric Anholt <eta@lclark.edu> Cc: Dag-Erling Smorgrav <des@ofug.org>, Marcel Moolenaar <marcel@xcllnt.net>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules Makefile Message-ID: <20030213223058.769DA2A8C1@canning.wemm.org> In-Reply-To: <1045175342.11981.1.camel@leguin>
next in thread | previous in thread | raw e-mail | index | archive | help
Eric Anholt wrote:
> On Thu, 2003-02-13 at 14:17, Peter Wemm wrote:
> > The lines in agpreg.h were what Eric added after the fact. This is an
> > i386-only chipset. It shouldn't have been in the sparc64, ia64, and alpha
> > builds. It certainly shouldn't be in powerpc whenever we start doing
> > builds for that.
> >
> > And IMHO, we certainly shouldn't be building/installing/releasing something
> > that we *know* hard locks the machine (Drew's report on agp_amd.c locking
> > up the UP1000).
>
> He said that he tried that when agp_amd first came out. agp_amd was
> broken on that chipset for all architectures for some time.
>
> I am working on a patch to only build the appropriate stuff for each
> arch.
That would be much better. Please feel free to replace my hack.
But please don't enable it on platforms that it doesn't work on.
For example, we have:
void
agp_flush_cache()
{
#ifdef __i386__
wbinvd();
#endif
}
There's no alpha or ia64 support, so don't enable it there unless this
cache flushing isn't needed.
Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030213223058.769DA2A8C1>