From owner-freebsd-arch@FreeBSD.ORG Sun Oct 16 16:20:48 2011 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8DA201065677 for ; Sun, 16 Oct 2011 16:20:48 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 4F09D8FC0C for ; Sun, 16 Oct 2011 16:20:48 +0000 (UTC) Received: by ggeq3 with SMTP id q3so3029384gge.13 for ; Sun, 16 Oct 2011 09:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=fhAEvaB2VZIc/PGGv4eaUnEI4rzrcCMvAgGAHGC5lH4=; b=rP42WwmB53DOY7h+m6bpdBnE3KgJ+FtPXn5y+FzGC6wNAmqlmJoTzWS2CoHZQ9g3PD 3wORFEdq6bCMChsLCnqg1ilwaL07hZT6WlTwGh08Oh+JgWpD/GrdMowzUW87kVFQJs1Y KZztLh5Nw26aRXfVVaaMNbZXO7eOKcXypyx2k= MIME-Version: 1.0 Received: by 10.236.174.105 with SMTP id w69mr18423578yhl.32.1318782047559; Sun, 16 Oct 2011 09:20:47 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.236.95.147 with HTTP; Sun, 16 Oct 2011 09:20:47 -0700 (PDT) In-Reply-To: <4EEA1F8B-9854-4C5C-A397-95AD454D3680@bsdimp.com> References: <4EEA1F8B-9854-4C5C-A397-95AD454D3680@bsdimp.com> Date: Mon, 17 Oct 2011 00:20:47 +0800 X-Google-Sender-Auth: wgQbSLNPY8q3PX-GfKV21bkVQeM Message-ID: From: Adrian Chadd To: Warner Losh Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-arch@freebsd.org Subject: Re: newbus bus access routines and bus_space_barrier() X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2011 16:20:48 -0000 On 16 October 2011 11:45, Warner Losh wrote: > Usually they are needed, but we get away without them often because they are needed in a limited set of circumstances and we have memory barriers in our locking primitives. Hm, so should this actively be fixed for drivers? I note iwn(4) does its own (correct looking?) barrier stuff. A few other drivers do. ath doesn't (yet). wi(4) doesn't yet do barriers, but someone supplied a patch that may work better on ppc if said barriers are included. Thanks, Adrian