From owner-freebsd-current@FreeBSD.ORG  Wed Jul 30 14:55:40 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id EF40237B401; Wed, 30 Jul 2003 14:55:40 -0700 (PDT)
Received: from fasterix.frmug.org (fasterix.frmug.org [137.194.36.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E67FC43FCB; Wed, 30 Jul 2003 14:55:39 -0700 (PDT)
	(envelope-from pb@fasterix.frmug.org)
Received: from fasterix.frmug.org (localhost [127.0.0.1])
	by fasterix.frmug.org (8.12.9/8.12.9) with ESMTP id h6ULtcXa001752
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 30 Jul 2003 23:55:38 +0200 (CEST)
	(envelope-from pb@fasterix.frmug.org)
Received: (from pb@localhost)
	by fasterix.frmug.org (8.12.9/8.12.9/Submit) id h6ULtclp001751;
	Wed, 30 Jul 2003 23:55:38 +0200 (CEST)
Date: Wed, 30 Jul 2003 23:55:38 +0200
From: Pierre Beyssac <pb@fasterix.frmug.org>
To: freebsd-current@freebsd.org
Message-ID: <20030730215538.GA1672@fasterix.frmug.org>
References: <20030730213249.GA900@fasterix.frmug.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030730213249.GA900@fasterix.frmug.org>
User-Agent: Mutt/1.4i
X-message-flag: Warning! Use of Microsoft Outlook is dangerous and makes your
	system susceptible to worms and viruses
cc: silby@freebsd.org
Subject: Re: bug in big pipe code causing performance problems
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jul 2003 21:55:41 -0000

On Wed, Jul 30, 2003 at 11:32:49PM +0200, Pierre Beyssac wrote:
> -		if (space > 0 && (wpipe->pipe_buffer.cnt < PIPE_SIZE)) {
> +		if (space > 0
> +		    && wpipe->pipe_buffer.cnt < wpipe->pipe_buffer.size) {

PS : not-so-obvious after all since the above is equivalent to
"(space > 0)" by itself, so I won't commit the above as is, and the
real fix might be something more complicated...
-- 
Pierre Beyssac	      	    pb@fasterix.frmug.org pb@fasterix.freenix.org
    Free domains: http://www.eu.org/ or mail dns-manager@EU.org