From owner-svn-src-all@freebsd.org  Sun Jan 27 15:50:37 2019
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D645414B1565;
 Sun, 27 Jan 2019 15:50:37 +0000 (UTC)
 (envelope-from mmel@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 7C0D16F33D;
 Sun, 27 Jan 2019 15:50:37 +0000 (UTC)
 (envelope-from mmel@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6C149A151;
 Sun, 27 Jan 2019 15:50:37 +0000 (UTC)
 (envelope-from mmel@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x0RFob5v080013;
 Sun, 27 Jan 2019 15:50:37 GMT (envelope-from mmel@FreeBSD.org)
Received: (from mmel@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id x0RFob5X080009;
 Sun, 27 Jan 2019 15:50:37 GMT (envelope-from mmel@FreeBSD.org)
Message-Id: <201901271550.x0RFob5X080009@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: mmel set sender to
 mmel@FreeBSD.org using -f
From: Michal Meloun <mmel@FreeBSD.org>
Date: Sun, 27 Jan 2019 15:50:37 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r343498 - head/sys/dev/extres/phy
X-SVN-Group: head
X-SVN-Commit-Author: mmel
X-SVN-Commit-Paths: head/sys/dev/extres/phy
X-SVN-Commit-Revision: 343498
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Rspamd-Queue-Id: 7C0D16F33D
X-Spamd-Bar: --
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-2.97 / 15.00];
 local_wl_from(0.00)[FreeBSD.org];
 NEURAL_HAM_MEDIUM(-1.00)[-0.998,0];
 NEURAL_HAM_SHORT(-0.98)[-0.976,0];
 ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Jan 2019 15:50:38 -0000

Author: mmel
Date: Sun Jan 27 15:50:36 2019
New Revision: 343498
URL: https://svnweb.freebsd.org/changeset/base/343498

Log:
  Properly define and declare phynode_topo_lock,
  it should be single global variable.
  
  X-MFC with:	r340845
  Noticed by:	phynode_topo_lock

Modified:
  head/sys/dev/extres/phy/phy.c
  head/sys/dev/extres/phy/phy_internal.h

Modified: head/sys/dev/extres/phy/phy.c
==============================================================================
--- head/sys/dev/extres/phy/phy.c	Sun Jan 27 15:29:58 2019	(r343497)
+++ head/sys/dev/extres/phy/phy.c	Sun Jan 27 15:50:36 2019	(r343498)
@@ -68,7 +68,7 @@ static phynode_method_t phynode_methods[] = {
 DEFINE_CLASS_0(phynode, phynode_class, phynode_methods, 0);
 
 static phynode_list_t phynode_list = TAILQ_HEAD_INITIALIZER(phynode_list);
-
+struct sx phynode_topo_lock;
 SX_SYSINIT(phy_topology, &phynode_topo_lock, "Phy topology lock");
 
 /* ----------------------------------------------------------------------------

Modified: head/sys/dev/extres/phy/phy_internal.h
==============================================================================
--- head/sys/dev/extres/phy/phy_internal.h	Sun Jan 27 15:29:58 2019	(r343497)
+++ head/sys/dev/extres/phy/phy_internal.h	Sun Jan 27 15:50:36 2019	(r343498)
@@ -78,6 +78,6 @@ struct phy {
 #define PHYNODE_XLOCK(_sc)	sx_xlock(&((_sc)->lock))
 #define PHYNODE_UNLOCK(_sc)	sx_unlock(&((_sc)->lock))
 
-struct sx		phynode_topo_lock;
+extern struct sx phynode_topo_lock;
 
 #endif /* DEV_EXTRES_PHY_INTERNAL_H */