From owner-svn-src-head@freebsd.org Tue Apr 26 21:59:23 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A8C3B1C616 for ; Tue, 26 Apr 2016 21:59:23 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BA7AC1985 for ; Tue, 26 Apr 2016 21:59:22 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-wm0-x22e.google.com with SMTP id e201so13625661wme.0 for ; Tue, 26 Apr 2016 14:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=sXP2r+1iJLkubX1ss2nps58USw92G46U09r7ttfr0mA=; b=T331t3cgJ6zVMjxY/UZyIo+Zp0XBohm1rO0lnLeLHZW9qSzYh21EPl8wmb9ayxy0CC INE98DnPX0coXYLuwA5pCP3G5/cVY6MIrM/77tKTG1Yr5hUfmrWXfX096Jv0sK18HMV2 aKI2DMiS2/bEl3OnFaJ5CHHgWZaOKK/PDa+4yXTI3qyaMI9tsU+rYMr8JxyTkHQGqxlP eRDhJ+Ys7YtbQf4UsgWX2+IMfwqmoBaTX0KofdCp5RETUjZM4NXMRtSjqs8iqCHYrVA1 4sMgMSZ4C+Xs0TvnFI+Mij5+RmCBJ9y10oGZqdywZQvw85CtcXXWUF99B4RvBBQDlBb8 aOaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=sXP2r+1iJLkubX1ss2nps58USw92G46U09r7ttfr0mA=; b=hH4rzonvTH9tHf2ZXqZGU9ajD6yHzwGnAi8+YIXixd2CkA6NcG13YgcS78JQ9qFHfI SEmWWQFPeTd11YQP+1bAkTnJ1d4qwLoWIGFqWdc8uGW2XjHEUsOpOhrJnzVqx8hM23Fg IBejv/CH60k3P1XhQ08w8NgNJlZDURGgOHOL5dM9xVcrj2QDOogZ/M8dnDbZgjDHBRE7 2xNwRciFQ4hvknpRPSUo7j0uYuPIrz9XXoLfiSLcnyiJCo+Y4zx+q2pbu+96EQwojQCg ug+qRBPL4bgCj7MlH3rzQqiZUd0azXl5EK1Ga/eUQUocCEXLlMFhij+V456/YE1Z8nhn pBog== X-Gm-Message-State: AOPr4FW0aD33c6z6p1q6grzR489ywYDXrXs0T2s223I5qJIFGu6Hf8/AMvDINX9+Ncn5J4oePG0seCCVP9403Ic1 MIME-Version: 1.0 X-Received: by 10.28.0.78 with SMTP id 75mr5924392wma.20.1461707961344; Tue, 26 Apr 2016 14:59:21 -0700 (PDT) Received: by 10.194.107.74 with HTTP; Tue, 26 Apr 2016 14:59:21 -0700 (PDT) In-Reply-To: <201604262144.u3QLi9ZX061166@repo.freebsd.org> References: <201604262144.u3QLi9ZX061166@repo.freebsd.org> Date: Tue, 26 Apr 2016 23:59:21 +0200 Message-ID: Subject: Re: svn commit: r298669 - head/sys/dev/iscsi_initiator From: Oliver Pinter To: "Conrad E. Meyer" , mav@freebsd.org Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2016 21:59:23 -0000 On Tue, Apr 26, 2016 at 11:44 PM, Conrad E. Meyer wrote: > Author: cem > Date: Tue Apr 26 21:44:08 2016 > New Revision: 298669 > URL: https://svnweb.freebsd.org/changeset/base/298669 > > Log: > iscsi_initiator(4): Fix use-after-free, double-free > > ism_stop() already destroys and frees 'sp', including a call to ic_destroy(). > Don't dereference 'sp' after ism_stop() and don't invoke ic_destroy() on the > freed memory either. > > Reported by: Coverity > CIDs: 1006109, 1304861 > Sponsored by: EMC / Isilon Storage Division MFC of this commit? > > Modified: > head/sys/dev/iscsi_initiator/iscsi.c > > Modified: head/sys/dev/iscsi_initiator/iscsi.c > ============================================================================== > --- head/sys/dev/iscsi_initiator/iscsi.c Tue Apr 26 21:19:12 2016 (r298668) > +++ head/sys/dev/iscsi_initiator/iscsi.c Tue Apr 26 21:44:08 2016 (r298669) > @@ -804,8 +804,6 @@ iscsi_stop(void) > TAILQ_FOREACH_SAFE(sp, &isc->isc_sess, sp_link, sp_tmp) { > //XXX: check for activity ... > ism_stop(sp); > - if(sp->cam_sim != NULL) > - ic_destroy(sp); > } > mtx_destroy(&isc->isc_mtx); > sx_destroy(&isc->unit_sx); > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org"