From owner-freebsd-current@FreeBSD.ORG Sat Oct 22 00:51:22 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 55064106566B; Sat, 22 Oct 2011 00:51:22 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id ABAF08FC08; Sat, 22 Oct 2011 00:51:21 +0000 (UTC) Received: by bkbzu17 with SMTP id zu17so7070904bkb.13 for ; Fri, 21 Oct 2011 17:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=IQ5Yzp0z5DIJAdAPgZfvxTMvYpRzDCdLzDUEU+z8NOM=; b=XWDEC3PnVZgSefFzvppgEQHhfrFP6A/AjBO9VKZT9afdz7KJmfHMQQJ426T9gqidaS WACkNGiZ7LKVKNeBXSVsvw9DSxh+04gEHHpakQacbF3JagZL14WQvcQIlWPDzfcOgqeD mpe/qkQ1YNDchFiQMaxifnbdc1SiMrqKn4Tgc= MIME-Version: 1.0 Received: by 10.204.140.202 with SMTP id j10mr11865800bku.66.1319244678916; Fri, 21 Oct 2011 17:51:18 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.204.39.12 with HTTP; Fri, 21 Oct 2011 17:51:18 -0700 (PDT) In-Reply-To: <20111021211221.GV59810@albert.catwhisker.org> References: <20111020114844.GK59810@albert.catwhisker.org> <20111020122121.GL59810@albert.catwhisker.org> <201110211636.05917.jhb@freebsd.org> <20111021211221.GV59810@albert.catwhisker.org> Date: Fri, 21 Oct 2011 17:51:18 -0700 X-Google-Sender-Auth: y_0NpkLlXQyhD-R8t22015yIcsA Message-ID: From: Craig Rodrigues To: David Wolfskill Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org Subject: Re: sys/conf/newvers.sh vs. subversion-1.7 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2011 00:51:22 -0000 Hi, Can you come up with a patch which invoke "svn info ." (if the svn binary exists)? This is slightly faster than svnversion. If "svn info ." doesn't error out, you can assume that the directory is under SVN control. -- Craig Rodrigues rodrigc@crodrigues.org On Fri, Oct 21, 2011 at 2:12 PM, David Wolfskill wro= te: > On Fri, Oct 21, 2011 at 04:36:05PM -0400, John Baldwin wrote: >> .... >> I'm not sure what the best fix is. =A0One could possibly always run svnv= ersion >> if it exists? > > Sure -- and use the result as long as the exit status is 0. =A0(It's > certainly possible that svnversion exists, but the sources in question > aren't in a subversion working copy, after all.) > > I could cobble up a patch to do that, if y'all like.... > > Alternatively, see the more extended comments I made to Jilles' comments > (to the PR) of a similar nature; > . =A0Summary: I beli= eve > that newvers.sh ought to be intrinsically SCM-agnostic. > > Peace, > david > -- > David H. Wolfskill =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0david@catwhisker.org > Depriving a girl or boy of an opportunity for education is evil. > > See http://www.catwhisker.org/~david/publickey.gpg for my public key. > --=20 Craig Rodrigues rodrigc@crodrigues.org