From owner-svn-src-all@freebsd.org Tue Dec 29 12:04:36 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7091CA54772; Tue, 29 Dec 2015 12:04:36 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0E5A31E8B; Tue, 29 Dec 2015 12:04:36 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm0-x242.google.com with SMTP id u188so35448919wmu.0; Tue, 29 Dec 2015 04:04:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ZsmSwpeJo8ZB7R15P6OUYoZ5vUgldN9z2eq5Qf2Aumk=; b=Z9/3gSLxyoJNiAZ8Hlr3w23f+46fU31JyMhN7kzJt2u2ADeWeSltQ9oJhfWLETHnrS 5XALqlTTgcBeHAjGE5celaPY53OwuUj2qQy0zhxYDMzQp4CtNLHFZ2ihYmgrrWf+dnMU E4qpOxuNfkKIeBEEhKUzl/YqJ0aXoS4ngLycPA214vGZooCz3UecO4Nl02xhRH5YWAak mSywSsM0R2sMh6k0zGvK8TaRcjO23xS7/JQR4FlB2krtpA7B5Xnt0dFtEEmHh4d9TRlo Hsxu1FHDSiinsgXEHRCaTN41lOcnvJZkEHnUQIWhIsrna2u6y7tXvD57Jc5QRcms9ZJO TWCA== X-Received: by 10.28.214.76 with SMTP id n73mr8117956wmg.52.1451390674455; Tue, 29 Dec 2015 04:04:34 -0800 (PST) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by smtp.gmail.com with ESMTPSA id o132sm47788178wmb.7.2015.12.29.04.04.33 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 29 Dec 2015 04:04:33 -0800 (PST) Date: Tue, 29 Dec 2015 13:04:31 +0100 From: Mateusz Guzik To: NGie Cooper Cc: John Baldwin , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Garrett Cooper Subject: Re: svn commit: r292626 - head/sys/kern Message-ID: <20151229120431.GB15969@dft-labs.eu> References: <201512222107.tBML7XUO053901@repo.freebsd.org> <3052030.KADVjZoIBd@ralph.baldwin.cx> <2BB34BE5-B312-42DA-B89E-F25B823B9831@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2BB34BE5-B312-42DA-B89E-F25B823B9831@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Dec 2015 12:04:36 -0000 On Tue, Dec 22, 2015 at 02:29:36PM -0800, NGie Cooper wrote: > > > On Dec 22, 2015, at 13:17, John Baldwin wrote: > > > > On Tuesday, December 22, 2015 09:07:33 PM Garrett Cooper wrote: > > … > > > It shouldn't be zero, I think == 1 would be best actually. > > I’ll boot up GENERIC and see whether or not it works with == 1. > Thanks :)! Any value other than in 1 is a bug. The value of 0 means the destination is not used, although it clearly is. Since the counter is signed, sufficiently big amount of users can actually make it negative, although that's an unrealistic for now. TL;DR please change it to equality check against 1. -- Mateusz Guzik