From owner-freebsd-current@FreeBSD.ORG Fri Sep 21 03:45:18 2007 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 59CEE16A417; Fri, 21 Sep 2007 03:45:18 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from mojo.ru (mojo.ru [84.252.152.63]) by mx1.freebsd.org (Postfix) with ESMTP id D3D2F13C44B; Fri, 21 Sep 2007 03:45:17 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from [192.168.0.16] (nc-76-4-28-21.dhcp.embarqhsd.net [76.4.28.21]) (authenticated bits=0) by mojo.ru (8.12.11.20060308/8.12.10) with ESMTP id l8L3jNc7010294 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 21 Sep 2007 07:45:25 +0400 Message-ID: <46F33E3A.8010508@FreeBSD.org> Date: Thu, 20 Sep 2007 23:44:58 -0400 From: "Constantine A. Murenin" Organization: Google Summer of Code 2007 Student @ The FreeBSD Project User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.5) Gecko/20041217 X-Accept-Language: en-gb, en-gb-oed, en, en-us, ru, ru-ru, ru-su MIME-Version: 1.0 To: Doug Barton References: <200709132302.l8DN2Tv5076033@repoman.freebsd.org> <46E9FC0C.70607@FreeBSD.org> <46F1A96F.2040602@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Leidinger , Shteryana Shopova , freebsd-current@FreeBSD.org, "Constantine A. Murenin" Subject: Re: GSoC2007: cnst-sensors.2007-09-13.patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2007 03:45:18 -0000 On 20/09/2007 19:12, Doug Barton wrote: > On Wed, 19 Sep 2007, Constantine A. Murenin wrote: > >> Thanks for testing! > > > Glad to help. In case it's interesting, I was doing the xorg update with > portmaster last night and I got several "PROCHOT asserted" messages on > my console at different times. I'm assuming that's expected behavior, > just curious if it's something bad, as in when that happens it's time to > turn off the laptop? (I didn't seem them when the happened, they were > there when I got back to check on the compiling.) Based on the fact that it's a laptop, I'm not too surprised -- the word 'laptop' in itself should not be taken literally due to the heat that these things produce -- you clearly don't want them on your lap. :-) >>> Two small comments about the rc.d stuff. First, the empty _flags >>> variable in defaults/rc.conf should be commented out. Second, the rc.d >> >> >> How so? I don't see any other empty _flags variables in >> defaults/rc.conf being commented out. > > > Well you missed named_flags. :) But seriously, I didn't realize that > things had gotten quite so out of hand with that ... never mind then. > >>> script needs the shutdown KEYWORD. >> >> >> Similarly, I don't see why this is needed -- it was not used by the >> scripts on which this script was based on > > > Which scripts? I realize that a distressingly large number of scripts > that start services don't have this keyword, but they should. I'll work > on a patch for that. At the same time, we don't want to add any new > scripts that make the same mistake. http://lists.freebsd.org/pipermail/p4-projects/2007-September/020980.html "add /etc/rc.d/sensorsd, modelled after ftpproxy and somewhat around powerd" >> Reading through rc(8) doesn't seem to suggest that this keyword would >> actually be applicable here. > > > As far as I can tell, you're starting a daemon, which means that it > should be cleanly shut down when the system exits. Again, this is not how the majority of other daemons do it. Moreover, I am not aware of any practical problems with the current approach. > Doug C.