From owner-cvs-all@FreeBSD.ORG Wed Jan 9 20:15:56 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5DBDB16A53A; Wed, 9 Jan 2008 20:15:56 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from mail09.syd.optusnet.com.au (mail09.syd.optusnet.com.au [211.29.132.190]) by mx1.freebsd.org (Postfix) with ESMTP id DDB2513C45A; Wed, 9 Jan 2008 20:15:55 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from server.vk2pj.dyndns.org (c220-239-20-82.belrs4.nsw.optusnet.com.au [220.239.20.82]) by mail09.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id m09KEO11030212 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 10 Jan 2008 07:14:26 +1100 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.2/8.14.1) with ESMTP id m09KEOcb005035; Thu, 10 Jan 2008 07:14:24 +1100 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.2/8.14.2/Submit) id m09KEOfq005034; Thu, 10 Jan 2008 07:14:24 +1100 (EST) (envelope-from peter) Date: Thu, 10 Jan 2008 07:14:24 +1100 From: Peter Jeremy To: Sam Leffler Message-ID: <20080109201424.GA4969@server.vk2pj.dyndns.org> References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> <20080109170850.GA27993@dragon.NUXI.org> <4785058B.1050507@errno.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BOKacYhQ+x31HxR3" Content-Disposition: inline In-Reply-To: <4785058B.1050507@errno.com> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Max Laier , src-committers@freebsd.org, cvs-all@freebsd.org, obrien@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2008 20:15:56 -0000 --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 09, 2008 at 09:34:03AM -0800, Sam Leffler wrote: >I observe that netbsd does these sorts of changes in sweeps over the tree= =20 >and w/ multiple people involved to review each other's work. I'd be more= =20 >confident if I saw commits like this include a "Reviewed by:" line. For this sort of commit, it should also be possible to check that you haven't broken anything by cmp(1)ing the .o files or manually preprocessing and diffing the preprocessed files. --=20 Peter Jeremy Please excuse any delays as the result of my ISP's inability to implement an MTA that is either RFC2821-compliant or matches their claimed behaviour. --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHhSsg/opHv/APuIcRAt4bAKCuBoG4hchde78zphaCpiDUKbmgUgCePNtB kFeL1rs/qkUsZl2GoHRVDm0= =J2v3 -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3--